Closed
Bug 553635
Opened 14 years ago
Closed 14 years ago
link libimgicon into libxul in GTK builds
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.3a4
People
(Reporter: ted, Assigned: ted)
References
Details
Attachments
(1 file)
|
3.03 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
As it turns out, the fix from bug 402742 changed it so that we no longer link directly to libgnomeui, we dlopen()ing it instead. Because of that, the leftovers from bug 273876 to always build it as a shared library are no longer necessary and we can just link it into libxul like we do everywhere else. I stumbled over this while fixing up Joel's patch in bug 525013, because he made it link statically but he missed a few spots that needed to be fixed to make it actually work. I figured I'd split it out to a separate bug because it will help libxul builds as well.
Attachment #433583 -
Flags: review?(benjamin)
|
||
Updated•14 years ago
|
Attachment #433583 -
Flags: review?(benjamin) → review+
|
Assignee | |
Comment 1•14 years ago
|
||
Pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/722ff789df89
Assignee: nobody → ted.mielczarek
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a4
|
||
Updated•14 years ago
|
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•