553651 - Enabled personas in addons manager will not update buttons of unused personas

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Tony Chung [:tchung]]

Attachment: Enabled Persona screenshot

When enabling a new persona over updating an older persona, the status of the older persona should reflect its no longer being used.  (eg. reshow the "Enable", "Remove" buttons)   

See screenshot

Repro:
1) install addons branch build: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a4pre) Gecko/20100319 Minefield/3.7a4pre
2) open addons manager
3) install 2 or more personas via getpersonas.com
4) Verify back in Appearance pane, switching between the installed personas will not update the older persona's status.  (like buttons)

Expected:
- Updating a persona should handle the older persona's status

Actual:
- Updating a new persona will not reflect the status of the older persons

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

HM, I wonder if this is an API issue with the personas provider. Will investigate.

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Nope, definitely a UI issue.

http://hg.mozilla.org/projects/addonsmgr/rev/5ab876c3693a

Comment 3

[Dave Townsend [:mossop]]

Landed on trunk as a part of bug 554007

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed on all platforms like Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a5pre) Gecko/20100511 Minefield/3.7a5pre ID:20100511030640

Blair, I would assume that can be completely covered by an automated test?

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #4)
> Blair, I would assume that can be completely covered by an automated test?

Yes.