Closed Bug 553743 Opened 14 years ago Closed 14 years ago

Fix "Force Copy Before Link" deps for shared

Categories

(Camino Graveyard :: General, defect)

1.9.2 Branch
All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: alqahira, Assigned: alqahira)

Details

(Whiteboard: [cm192test])

Attachments

(1 file)

The "Force Copy Before Link" phase depended on both Breakpad and libmozlcms.dylib.

libmozlcms.dylib is gone, and libqcms is only built "stand-alone" in static, as libqcms.a.

Stuart, what dylib should I replace libmozlcms with in CaminoApp's copy-before-link phase?

http://hg.mozilla.org/users/alqahira_ardisson.org/camino-1.9.2-test/file/3d797c134820/Camino.xcodeproj/project.pbxproj#l6103
I believe any library listed in the Copy Libraries step should do it.
Attached patch FixSplinter Review
Let's use libxpcom_core.dylib, then.
Attachment #433776 - Flags: superreview?(stuart.morgan+bugzilla)
Comment on attachment 433776 [details] [diff] [review]
Fix

Also, I noticed when changing this that there's a checkbox to suppress showing the miles of environment variables for script phases.

Can we dispense with that in all our script phases?  If we ever need to debug the script phases that use them, it's easy enough to turn them back on, and in the meantime it saves tons of lines of scrollback/tinderbox logs.
Comment on attachment 433776 [details] [diff] [review]
Fix

sr=smorgan
Attachment #433776 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+
(In reply to comment #3)
> Can we dispense with that in all our script phases?

Fine by me, especially since we don't do much fancy stuff with environment variables in our scripts anyway. Although it might be good to leave it on for one script phase, so we have one copy of all the variables for reference; your call.
Landed this patch in the test repo: http://hg.mozilla.org/users/alqahira_ardisson.org/camino-1.9.2-test/rev/ec48bd71fe77
Status: NEW → ASSIGNED
Whiteboard: [cm192test]
http://hg.mozilla.org/camino/rev/9de0a105a2fa
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.