Closed Bug 553852 Opened 14 years ago Closed 14 years ago

[D2D] d2d_acquire_source/dest are leaking their image surface

Categories

(Core :: Graphics, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bas.schouten, Assigned: bas.schouten)

References

Details

Attachments

(1 file)

Currently we don't call cairo_destroy_image when d2d_release_source/dest are called. We should.
Attachment #433766 - Flags: review?(jmuizelaar)
Attachment #433766 - Flags: review?(jmuizelaar) → review+
Comment on attachment 433766 [details] [diff] [review]
Clean up used image surface

>     D2D1_RECT_U rect;
>     D2D1_SIZE_U size = d2dsurf->rt->GetPixelSize();
>     rect.left = rect.top = 0;
>     rect.right = size.width;
>     rect.bottom = size.height;
>+    cairo_surface_destroy(&image->base);
>     softTexture->Unmap(0);

Some space around this line would be nice.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: