553882 - [OS/2] Plugin-related coding errors

Status: RESOLVED FIXED

(Core Graveyard :: Widget: OS/2, defect)

Description

[Rich Walsh]

Attachment: plugin-related fixes for trunk

This patch fixes 3 plugin-related bugs in nsWindow & nsPluginNativeWindowOS2.

- If a plugin window is destroyed before the page containing it, the window created to clip the plugin remains as an area that is never updated.  This patch adds code to the plugin widget's destructor to destroy the clip window.

- When scrolling, plugin windows that overlap the scrolled area should be invalidated.  This corrects a coding error that caused the window being scrolled to be invalidated rather than the plugins.

- If a plugin is displaying a popup menu, clicking elsewhere on the page dismisses the menu but returns the focus to the plugin rather than the page.  New tests have been added to prevent this.

Note:  all of these bugs exist in 1.9.2;  however a separate patch will be needed.

Comment 1

[Walter Meinl]

(In reply to comment #0)
> Created an attachment (id=433781) [details]
> Note:  all of these bugs exist in 1.9.2;  however a separate patch will be
> needed.
Are you planning to write a patch for 1.9.2?

Comment 2

[Rich Walsh]

Attachment: plugin-related fixes for 1.9.2

Walter, I don't have a 1.9.2 tree, so could you confirm that these fixes apply & compile properly?  Thanks...

Comment 3

[Walter Meinl]

Comment on attachment 436937 [details] [diff] [review]
plugin-related fixes for 1.9.2

Yep, works as a charme

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/456b934bab9e

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/63bc0b796424