553957 - Clean CSS frame constructor code related to select element

Status: NEW

(Core :: Layout: Form Controls, enhancement)

Description

[Mounir Lamouri (:mounir)]

Since select element has now a default value when multiple attribute is used, according to bz, the CSS frame constructor could be cleaned.
See bug 551846.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Specifically, this code in nsCSSFrameConstructor::ConstructSelectFrame:

3042     sel->GetSize(&size); 
3043     PRBool multipleSelect = PR_FALSE;
3044     sel->GetMultiple(&multipleSelect);
3045      // Construct a combobox if size=1 or no size is specified and its multiple select
3046     if (((1 == size || 0 == size) || (kNoSizeSpecified  == size)) && (PR_FALSE == multipleSelect)) {

Or will it still be possible to have size == 0 or size == 1 while having multiple set?

Comment 2

[Mounir Lamouri (:mounir)]

If multiple is set, size can be set to 1. Exactly like it can be set to 1 if multiple is not set.
However, 0 is a forbidden value for size so if setAttribute('size', 0) is call, IDL attribute should reflect size=1 if !multiple or size=4 if multiple is set.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Hmm.  It doesn't sound like we can simplify this much, then.  :(