Closed Bug 554097 Opened 10 years ago Closed 10 years ago

add-ons in add-ons manager in safe mode should look disabled

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla2.0b7

People

(Reporter: aryx, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: ux-consistency)

add-ons in add-ons manager in safe mode should look disabled, currently there is the fresh green puzzle icon for normal active add-ons and the faded one for normal inactive ones.

Maybe this could be fixed in the add-ons manager overhaul?
Blocks: safe-mode
Blocks: 586066
Keywords: ux-consistency
OS: Windows XP → All
Hardware: x86 → All
Depends on: 597027
Whiteboard: [needs 597027]
Fixed by bug 597027, or at least they now look as disabled as disabled add-ons do.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [needs 597027]
Target Milestone: --- → mozilla2.0b8
Verified fixed on all platforms with builds like Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101008 Firefox/4.0b8pre

Dave, beside automated tests with jetpacks I assume we should have a manual test for the safe mode.
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
Flags: in-litmus?
Yeah we don't have an automated suite that runs safe mode so this would need to be manual.
Flags: in-testsuite? → in-testsuite-
Dave, do you know if it is possible to prevent the safe mode dialog during startup? I don't think there is a pref for, or? That would even block us from writing a Mozmill test.
I don't think you can block it, not sure why that would effect mozmill tests though, surely mozmill can't work regardless since it relies on an extension?
Well, that's true! JSbridge and Mozmill have to be installed and be active. So yes, no way to test with Mozmill.
Target Milestone: mozilla2.0b8 → mozilla2.0b7
The message "All add-ons have been disabled by safe mode" appears on three views, Extensions, Appearance, and Plugins. The items on the first two lists are appear disabled, but the plugins are not grey. Are the plugsins disabled?

If yes, they should be grey. If not disabled, should the message appear on that view?
(In reply to comment #7)
> The message "All add-ons have been disabled by safe mode" appears on three
> views, Extensions, Appearance, and Plugins. The items on the first two lists
> are appear disabled, but the plugins are not grey. Are the plugsins disabled?
> 
> If yes, they should be grey. If not disabled, should the message appear on that
> view?

Can you please file a new bug for that issue? It should be tracked separately whether which path is the right one. Thanks for catching this.
(In reply to comment #7)
> Are the plugsins disabled?

Sadly, no. See bug 342333.

> Can you please file a new bug for that issue? It should be tracked separately
> whether which path is the right one. Thanks for catching this.

We already have bug 492271 for this.
No longer blocks: 623199
Manual test covered by:
https://litmus.mozilla.org/show_test.cgi?id=15315
Flags: in-litmus? → in-litmus+
You need to log in before you can comment on or make changes to this bug.