554097 - add-ons in add-ons manager in safe mode should look disabled

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

add-ons in add-ons manager in safe mode should look disabled, currently there is the fresh green puzzle icon for normal active add-ons and the faded one for normal inactive ones.

Maybe this could be fixed in the add-ons manager overhaul?

Comment 1

[Dave Townsend [:mossop]]

Fixed by bug 597027, or at least they now look as disabled as disabled add-ons do.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed on all platforms with builds like Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101008 Firefox/4.0b8pre

Dave, beside automated tests with jetpacks I assume we should have a manual test for the safe mode.

Comment 3

[Dave Townsend [:mossop]]

Yeah we don't have an automated suite that runs safe mode so this would need to be manual.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Dave, do you know if it is possible to prevent the safe mode dialog during startup? I don't think there is a pref for, or? That would even block us from writing a Mozmill test.

Comment 5

[Dave Townsend [:mossop]]

I don't think you can block it, not sure why that would effect mozmill tests though, surely mozmill can't work regardless since it relies on an extension?

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Well, that's true! JSbridge and Mozmill have to be installed and be active. So yes, no way to test with Mozmill.

Comment 7

[B.J. Herbison]

The message "All add-ons have been disabled by safe mode" appears on three views, Extensions, Appearance, and Plugins. The items on the first two lists are appear disabled, but the plugins are not grey. Are the plugsins disabled?

If yes, they should be grey. If not disabled, should the message appear on that view?

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #7)
> The message "All add-ons have been disabled by safe mode" appears on three
> views, Extensions, Appearance, and Plugins. The items on the first two lists
> are appear disabled, but the plugins are not grey. Are the plugsins disabled?
> 
> If yes, they should be grey. If not disabled, should the message appear on that
> view?

Can you please file a new bug for that issue? It should be tracked separately whether which path is the right one. Thanks for catching this.

Comment 9

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #7)
> Are the plugsins disabled?

Sadly, no. See bug 342333.

> Can you please file a new bug for that issue? It should be tracked separately
> whether which path is the right one. Thanks for catching this.

We already have bug 492271 for this.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Manual test covered by:
https://litmus.mozilla.org/show_test.cgi?id=15315