554139 - [k] JSON(P) support for search

Status: VERIFIED FIXED

(support.mozilla.org :: Search, defect, P1)

Description

[James Socol [:jsocol, :james]]

We use the JSON search results in the AAQ, so we do need to support this right away.

Comment 1

[Paul Craciunoiu [:paulc]]

r? on branch bug-554139 at:
http://github.com/pcraciunoiu/kitsune/commit/7aa2483d4d529ea856a0ffcba3eb905830aa7f9f

I ported James' PHPUnit test over to django (original: bug 543116 attachment 424340 [details]).

Worth noting: we use item.search_summary instead of item.description. When I tested this, I first saw only titles in the AAQ form results. So I changed |.description| to |.search_summary| in webroot/forumquestion.js:391.

Comment 2

[James Socol [:jsocol, :james]]

(In reply to comment #1)
> r? on branch bug-554139 at:
> http://github.com/pcraciunoiu/kitsune/commit/7aa2483d4d529ea856a0ffcba3eb905830aa7f9f

r+.

Comment 3

[James Socol [:jsocol, :james]]

http://github.com/jsocol/kitsune/commit/bf9f40a187bec8f5fbfe8ecc4d7004ab391f141d
Fixed.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

tests++; WebQA really appreciates all the tests that are landing!

What's the manual test for this, BTW?  Just loading http://support-stage-new.mozilla.com/en-US/search?q=deleting+bookmarks&format=json that it's JSON?

Comment 5

[James Socol [:jsocol, :james]]

Checking that it's a JSON MIME-type and that it's valid (http://jsonlint.com/) and then adding a |callback=foo| parameter and checking that it's a JavaScript MIME-type.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED:

http://support-stage-new.mozilla.com/en-US/search?q=deleting%20bookmarks&format=json&callback=arr[1] is application/x-javascript