554149 - Contribution helper crashes when pledge.raised is None

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Jeff Balogh (:jbalogh)]

Traceback (most recent call last):

 File "/data/virtualenvs_preview/zamboni/lib/python2.6/site-packages/django/core/handlers/base.py", line 101, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/amo_python/www/preview/zamboni/apps/addons/views.py", line 27, in decorated
   return f(request, *args, **kwargs)

 File "/data/amo_python/www/preview/zamboni/apps/addons/views.py", line 97, in addon_detail
   return jingo.render(request, 'addons/details.html', data)

 File "/data/virtualenvs_preview/zamboni/lib/python2.6/site-packages/jingo/__init__.py", line 68, in render
   rendered = template.render(**context)

 File "/data/virtualenvs_preview/zamboni/lib/python2.6/site-packages/jinja2/environment.py", line 705, in render
   return self.environment.handle_exception(exc_info, True)

 File "/data/amo_python/www/preview/zamboni/apps/addons/templates/addons/details.html", line 1, in top-level template code
   {% extends "base.html" %}

 File "/data/amo_python/www/preview/zamboni/templates/base.html", line 59, in top-level template code
   {% block main_content %}

 File "/data/amo_python/www/preview/zamboni/templates/base.html", line 66, in block "main_content"
   {% block content %}{% endblock %}

 File "/data/amo_python/www/preview/zamboni/apps/addons/templates/addons/details.html", line 37, in block "content"
   contribution(

 File "/data/amo_python/www/preview/zamboni/apps/addons/helpers.py", line 83, in contribution
   'pledge': pledge,

 File "/data/virtualenvs_preview/zamboni/lib/python2.6/site-packages/jinja2/environment.py", line 705, in render
   return self.environment.handle_exception(exc_info, True)

 File "/data/amo_python/www/preview/zamboni/apps/addons/templates/addons/contribution.html", line 3, in top-level template code
   {% cache pledge %}

 File "/data/virtualenvs_preview/zamboni/lib/python2.6/site-packages/caching/ext.py", line 63, in _cache_support
   return caching.base.cached(caller, key, timeout)

 File "/data/virtualenvs_preview/zamboni/lib/python2.6/site-packages/caching/base.py", line 242, in cached
   val = function()

 File "/data/amo_python/www/preview/zamboni/apps/addons/templates/addons/contribution.html", line 23, in template
   data-ratio="{{ pledge.raised / pledge.target|float }}"

TypeError: unsupported operand type(s) for /: 'NoneType' and 'float'

Comment 1

[Jeff Balogh (:jbalogh)]

http://github.com/jbalogh/zamboni/commit/05f47af8ee769b1f23fd0866bd77abc3f0b43ecd

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/z/en-US/firefox/addon/64250/.

(OMG, thanks for the tests!)

Comment 3

[Fred Wenzel [:wenzel]]

Very nice, thanks for fixing my bug for me ;)

Comment 4

[Jeff Balogh (:jbalogh)]

In truth, I needed something to test so I could get us to 300.