Closed Bug 554170 Opened 10 years ago Closed 10 years ago

npfunctions.h popup enabled state functions shouldn't return bool as the impl returns void

Categories

(Core :: Plug-ins, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: bent.mozilla, Assigned: jaas)

Details

Attachments

(1 file, 1 obsolete file)

14.51 KB, patch
bent.mozilla
: review+
Details | Diff | Splinter Review
We need to make the typedefs return void and stop casting function pointers so that we catch this kind of thing.
Assignee: nobody → joshmoz
Attached patch fix v1.0 (obsolete) — Splinter Review
This fixes the problem and takes a step in the right direction for the browser's function table initialization. I don't have time to actually make the struct const right now.
Attachment #434127 - Flags: review?(bent.mozilla)
Comment on attachment 434127 [details] [diff] [review]
fix v1.0

Looks good to me!
Attachment #434127 - Flags: review?(bent.mozilla) → review+
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/07da861feaad
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
backed out due to IPC bustage

http://hg.mozilla.org/mozilla-central/rev/6350335e13f2
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #434127 - Attachment is obsolete: true
Attachment #435006 - Flags: review?(bent.mozilla)
Comment on attachment 435006 [details] [diff] [review]
fix v1.1 (IPC fix)

Sorry, should have warned you about that.
Attachment #435006 - Flags: review?(bent.mozilla) → review+
fix v1.1 pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/2348e44ee598
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.