Closed Bug 554324 Opened 10 years ago Closed 8 years ago

stop setting MOZ_PKG_VERSION when unnecessary

Categories

(Release Engineering :: General, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: coop)

References

Details

(Whiteboard: [automation][oldbug])

Attachments

(2 files, 1 obsolete file)

We set MOZ_PKG_VERSION in the ReleaseBuild and ReleaseRepack factories in order to get the right filenames for RC releases, when the in-repo version isn't set to what we need. Eg, for 3.6rc1 the in-repo version was '3.6', but the packages needed to be '3.6rc1'.

For all releases other than RCs, this only does harm. The packaging code would work perfectly fine without it set, and in fact, it masks problems such as the one we hit in 3.6.2build2 (when the in-repo version is wrong, forcing the packages to have the right version makes that issue less visible).

We should definitely stop setting this variable when appVersion == version.
Priority: -- → P3
Whiteboard: [automation]
Assignee: nobody → armenzg
Priority: P3 → P4
It's worth noting that we don't do RCs like we did when this bug was filed (we use version=5.0, appVersion=5.0), but *now* we do version=5.0b1, appVersion=5.0 for Betas, so the override is still necessary for them.
Whiteboard: [automation] → [automation][mozharness]
Whiteboard: [automation][mozharness] → [automation][oldbug]
Priority: P4 → P2
Priority: P2 → P3
Too much in my plate.
Assignee: armenzg → nobody
Whiteboard: [automation][oldbug] → [automation][oldbug][triagefollowup]
Assignee: nobody → coop
OS: Mac OS X → All
Whiteboard: [automation][oldbug][triagefollowup] → [automation][oldbug]
cc-ing Callek in case he'll need to change the CC factories.
Status: NEW → ASSIGNED
Priority: P3 → P2
I've opted to still set MOZ_PKG_VERSION when appVersion isn't provided because that preserves the existing behavior. I could be easily convinced otherwise.

Corresponding l10n script patch coming right up.
Attachment #594591 - Flags: review?(bhearsum)
Oops, posted an earlier version of the patch by mistake.
Attachment #594592 - Attachment is obsolete: true
Attachment #594593 - Flags: review?(bhearsum)
Attachment #594592 - Flags: review?(bhearsum)
Attachment #594591 - Flags: review?(bhearsum) → review+
Attachment #594593 - Flags: review?(bhearsum) → review+
Comment on attachment 594591 [details] [diff] [review]
Only set MOZ_PKG_VERSION when appVersion != version (buildbotcustom)

https://hg.mozilla.org/build/buildbotcustom/rev/48bad9e07961
Attachment #594591 - Flags: checked-in+
Comment on attachment 594593 [details] [diff] [review]
Only set MOZ_PKG_VERSION in create-release-repacks.py when appVersion != version

https://hg.mozilla.org/build/tools/rev/159af2d7f3f6
Attachment #594593 - Flags: checked-in+
This is live now as of 1300 PST.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Depends on: 727751
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.