Closed Bug 554331 Opened 10 years ago Closed 10 years ago

Thunderbird Mac nightly builds broken (making complete update) due to not being able to find the right topsrcdir

Categories

(MailNews Core :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.3a1

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

Why this doesn't affect SeaMonkey directly, I'm not sure. I suspect its because they don't define MOZ_BRANDING_DIRECTORY in confvars.sh (yet).

Anyway, the basic issue is that when we're configuring the mozilla-central part of the build system the variable $topsrcdir isn't set.

It turns out that configure only gets this as a side-effect from mozconfig2configure, and the correct variable to use is ${_topsrcdir}.

This only applies to items evaluated whilst configure is running. For items in single quotes, that are later evaluated by make, then $topsrcdir is exactly what we want (so no changes to those items).

Attaching patch to fix the instances where necessary (not fixing Calendar as Sunbird isn't going to be supported on trunk/1.9.2).
Attached patch The fixSplinter Review
Attachment #434248 - Flags: review?(gozer)
Oh, and for reference, I committed a similar patch to Firefox's configure.in with r=ted over irc:

http://hg.mozilla.org/mozilla-central/rev/3f694f889f38
Attachment #434248 - Flags: review?(gozer) → review+
Checked in: http://hg.mozilla.org/comm-central/rev/09fdfcc147b5
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Target Milestone: --- → Thunderbird 3.1b2
Target Milestone: Thunderbird 3.1b2 → Thunderbird 3.2a1
You need to log in before you can comment on or make changes to this bug.