554461 - [typedarray] use more NumberTraits

Status: RESOLVED INCOMPLETE

(Core :: JavaScript Engine, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

The typed array patch in bug 550351 could benefit from NumberTraits in a few ways:

1) use StringToNumberType instead of js_ValueToNumber when converting known strings;

2) Use NumberTraits<NativeType>::toSelfType(d) as arg to setIndex, to ensure compile-time optimization instead of depending on the compiler to be smart enough to remove dead code in the big if block chain

3) Use NumberTraits::NaN() in nativeFromValue

Comment 1

[Boris Zbarsky [:bzbarsky]]

vlad, do you want to take this, or should I?