Closed
Bug 554472
Opened 15 years ago
Closed 15 years ago
Only sync prefs under extensions.weave.prefs.sync. (with a trailing dot)
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
1.2
People
(Reporter: Mardak, Assigned: Mardak)
References
Details
Attachments
(1 file)
2.85 KB,
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
The current prefs sync code looks for prefs under "extensions.weave.prefs.sync" instead of "extensions.weave.prefs.sync." so if any pref happens to be prefixed with sync, e.g., syncID, it'll get caught and try to sync a pref "D".
Assignee | ||
Comment 1•15 years ago
|
||
We'll probably want to clean up the code at some point.. Not sure why there's two separate getters instead of something shared. And it caches one time, so new prefs would need a restart to catch.
Comment 2•15 years ago
|
||
Comment on attachment 434376 [details] [diff] [review]
v1
*shudder* prefapi makes me sad. I can't wait to audit the rest of this...
Attachment #434376 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 3•15 years ago
|
||
http://hg.mozilla.org/labs/weave/rev/948c4d25ecc3
Add a "." to the end of WEAVE_SYNC_PREFS value and fix up uses that did extra work to remove the dot (or something that might not have been a dot).
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
Updated•6 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•