554487 - crash @ morkRowMap::Hash

Status: RESOLVED WONTFIX

(MailNews Core :: Database, defect)

Description

[Wayne Mery (:wsmwk)]

crash [@ morkRowMap::Hash(morkEnv*, void const*)]
~#200 crash for v3.0.3

3 of 3 crash comments mention importing:
importing from a CSV file from Nokia PC Suite (E71 phone) to the Address book is very problematic.
I was importing my contacts from csv file format 3200 + entries
I just install it and after specifying to import settings, data, etc.. from MS Outlook it crashed.

the first one
bp-a298c5cb-aa55-4317-aa7d-96f002100316
0	thunderbird.exe	morkRowMap::Hash	 db/mork/src/morkRowMap.cpp:133
1	thunderbird.exe	morkMap::Get	db/mork/src/morkMap.cpp:692
2	thunderbird.exe	morkAtomBodyMap::GetAtom	db/mork/src/morkAtomMap.cpp:244
3	thunderbird.exe	morkTable::AddRow	db/mork/src/morkTable.cpp:1423
4	thunderbird.exe	morkTable::AddRow	db/mork/src/morkTable.cpp:661
5	thunderbird.exe	nsAddrDatabase::AddCardRowToDB	mailnews/addrbook/src/nsAddrDatabase.cpp:2096
6	xpcom_core.dll	NS_InvokeByIndex_P	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:102
7	xpcom_core.dll	nsProxyObjectCallInfo::Run	xpcom/proxy/src/nsProxyEvent.cpp:181
8	xpcom_core.dll	nsThread::ProcessNextEvent	xpcom/threads/nsThread.cpp:521
9	xpcom_core.dll	NS_ProcessNextEvent_P	objdir-tb/mozilla/xpcom/build/nsThreadUtils.cpp:247
10	thunderbird.exe	nsXULWindow::ShowModal	xpfe/appshell/src/nsXULWindow.cpp:415
11	thunderbird.exe	nsContentTreeOwner::ShowAsModal	xpfe/appshell/src/nsContentTreeOwner.cpp:528
12	thunderbird.exe	nsWindowWatcher::OpenWindowJSInternal	embedding/components/windowwatcher/src/nsWindowWatcher.cpp:1004
13	thunderbird.exe	nsWindowWatcher::OpenWindowJS	embedding/components/windowwatcher/src/nsWindowWatcher.cpp:488
14	thunderbird.exe	nsGlobalWindow::OpenInternal	dom/src/base/nsGlobalWindow.cpp:7435
15	thunderbird.exe	nsGlobalWindow::OpenDialog	dom/src/base/nsGlobalWindow.cpp:5200

Comment 1

[Tim Anthony Manuel]

"Import Address Book UI" doesn't seem to provide a very good interface when it comes to CSV. Several fields/data headers were missing from thunderbird's address book. That's why some of my imported contacts didn't have any mobile number associated to them even if they had on my phone. I also checked the CSV using notepad/MS Excel and i saw that the mobile number is on a field not present on thunderbird.

Comment 2

[Wayne Mery (:wsmwk)]

Mac crash appears to be the same 
morkRowMap::Hash(morkEnv*, void const*) const
bp-eac391da-43c3-408e-a74e-c9a152110108
EXC_BAD_ACCESS / KERN_PROTECTION_FAILURE
0xc

Comment 3

[Wayne Mery (:wsmwk)]

bp-1661b248-eb0e-4322-8900-d031b2130411

0	xul.dll	morkRowMap::Hash	db/mork/src/morkRowMap.cpp:101
1	xul.dll	morkMap::grow	db/mork/src/morkMap.cpp:545
2	xul.dll	morkMap::Put	db/mork/src/morkMap.cpp:579
3	xul.dll	morkAtomAidMap::AddAtom	db/mork/src/morkAtomMap.cpp:182
4	xul.dll	morkTable::AddRow	db/mork/src/morkTable.cpp:1403
5	xul.dll	morkBuilder::OnNewRow	db/mork/src/morkBuilder.cpp:509
6	xul.dll	morkParser::ReadRow	db/mork/src/morkParser.cpp:636
7	xul.dll	morkParser::ReadTable	db/mork/src/morkParser.cpp:756
8	xul.dll	morkParser::ReadContent	db/mork/src/morkParser.cpp:1402
9	xul.dll	morkParser::OnPortState	db/mork/src/morkParser.cpp:1448
10	xul.dll	morkParser::ParseChunk	db/mork/src/morkParser.cpp:1506
11	xul.dll	morkParser::ParseMore	db/mork/src/morkParser.cpp:1542 

matjk7@8658 97/*virtual*/ mork_u4 //
matjk7@8658 98morkRowMap::Hash(morkEnv* ev, const void* inKey) const
matjk7@8658 99{
matjk7@8658 100 MORK_USED_1(ev);
matjk7@8658 101 return (*(const morkRow**) inKey)->HashRow(); 

matjk7@8658 536 /* move all old keys and values to the new arrays: */
matjk7@8658 537 MORK_MEMCPY(mMap_Keys, old.mHashArrays_Keys, keyBulk);
matjk7@8658 538 if ( valBulk ) /* are values nonzero sized? */
matjk7@8658 539 MORK_MEMCPY(mMap_Vals, old.mHashArrays_Vals, valBulk);
matjk7@8658 540
matjk7@8658 541 mMap_FreeList = newFreeList; /* remaining assocs are free */
matjk7@8658 542
matjk7@8658 543 while ( ++newAssocs < newFreeList ) /* rehash another old assoc? */
matjk7@8658 544 {
matjk7@8658 545 morkAssoc** top = newBuckets + (this->Hash(ev, key) % newSlots);

Comment 4

[Wayne Mery (:wsmwk)]

Quite rare
bp-350174ed-49be-4f2d-bf81-1ce1d0190928 68.1.1
0 xul.dll morkRowMap::Hash(morkEnv*, void const*) comm/db/mork/src/morkRowMap.cpp:88 context
1 xul.dll morkMap::grow(morkEnv*) comm/db/mork/src/morkMap.cpp:471 cfi
2 xul.dll morkMap::Put(morkEnv*, void const*, void const*, void*, void*, unsigned char**) comm/db/mork/src/morkMap.cpp:501 cfi
3 xul.dll morkAtomAidMap::AddAtom(morkEnv*, morkBookAtom*) comm/db/mork/src/morkAtomMap.cpp:157 cfi
4 xul.dll morkTable::AddRow(morkEnv*, morkRow*) comm/db/mork/src/morkTable.cpp:1260 cfi
5 xul.dll morkTable::AddRow(nsIMdbEnv*, nsIMdbRow*) comm/db/mork/src/morkTable.cpp:571 cfi
6 xul.dll nsMsgDatabase::CreateNewThread(unsigned int, char const*, nsMsgThread**) comm/mailnews/db/msgdb/src/nsMsgDatabase.cpp:3911 cfi
7 xul.dll nsMsgDatabase::AddNewThread(nsMsgHdr*) comm/mailnews/db/msgdb/src/nsMsgDatabase.cpp:4342 cfi
8 xul.dll nsMsgDatabase::ThreadNewHdr(nsMsgHdr*, bool&) comm/mailnews/db/msgdb/src/nsMsgDatabase.cpp:4128 cfi
9 xul.dll nsMsgDatabase::AddNewHdrToDB(nsIMsgDBHdr*, bool) comm/mailnews/db/msgdb/src/nsMsgDatabase.cpp:3124 cfi
10 xul.dll nsParseNewMailState::PublishMsgHeader(nsIMsgWindow*) comm/mailnews/local/src/nsParseMailbox.cpp:1729 cfi

Comment 5

[Wayne Mery (:wsmwk)]

With bug 1572000 and addressbook rewrite coming, no mork crashes ranking above #160, and no one wanting to touch Mork code, it's safe to say that no one is going to fix any currently reported mork crash. Thus => wontfix (and we don't have to see these rare crashes as open bugs anymore)