Closed Bug 554549 Opened 13 years ago Closed 13 years ago

Calls to AvmAssert, should be NanoAssert, in NanoJIT module

Categories

(Core Graveyard :: Nanojit, defect)

Product:
Core Graveyard
Component:
Nanojit
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: wmaddox, Assigned: wmaddox)

Details

(Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey, fixed-in-tamarin)

Attachments

(2 files, 1 obsolete file)

TM: Replace AvmAssert with NanoAssert (1 occurance)
471 bytes, patch
n.nethercote
: review+
Details | Diff | Splinter Review
NJ: replace AvmAssert with NanoAssert everywhere, and remove AvmAssert from nanojit-central/avmplus.h
2.79 KB, patch
n.nethercote
: review+
Details | Diff | Splinter Review 
There are several occurrences of AvmAssert in the NanoJIT module.
In tamarin-redux:

./Assembler.cpp:   AvmAssert(_allocator.countActive() == 0);
./Assembler.cpp:   AvmAssert(_allocator.countActive() == 0);
./CodeAlloc.cpp:   AvmAssert(!blk->isFree);

These presumably should be NanoAssert instead.
Assignee: nobody → wmaddox
Attachment #434715 - Flags: review?(edwsmith)
Comment on attachment 434715 [details] [diff] [review]
Change stray instances of AvmAssert in NanoJIT to NanoAssert

Cool, I will commit these as well.
Attachment #434715 - Flags: review?(edwsmith) → review+
Assignee: wmaddox → nobody
Component: JIT Compiler (NanoJIT) → Nanojit
Product: Tamarin → Core
QA Contact: nanojit → nanojit
I took the opportunity to erase all remaining traces of AvmAssert from nanojit-central; requires one tracemonkey change as well.
Attachment #434715 - Attachment is obsolete: true
Attachment #434740 - Flags: review?(nnethercote)
Comment on attachment 434740 [details] [diff] [review]
NJ: replace AvmAssert with NanoAssert everywhere, and remove AvmAssert from nanojit-central/avmplus.h

Nice.  I'd been wondering about that.
Attachment #434740 - Flags: review?(nnethercote) → review+
Attachment #434734 - Flags: review?(nnethercote) → review+
Comment on attachment 434740 [details] [diff] [review]
NJ: replace AvmAssert with NanoAssert everywhere, and remove AvmAssert from nanojit-central/avmplus.h

http://hg.mozilla.org/projects/nanojit-central/rev/aeb486b1d227
Whiteboard: fixed-in-nanojit
http://hg.mozilla.org/tracemonkey/rev/36d36db4d340
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tracemonkey
NJ patch in TR
http://hg.mozilla.org/tamarin-redux/rev/94af991a4f86
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey → fixed-in-nanojit, fixed-in-tracemonkey, fixed-in-tamarin
Assignee: nobody → wmaddox
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
reopening: as a matter of protocol, nanojit bugs are left open until both tamarin and tracemonkey have them integrated into their shipping branches.. (maybe we need flags to indicate status?).  TR is "done", moz will mark closed once they're "done".
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
http://hg.mozilla.org/mozilla-central/rev/36d36db4d340
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.