Bug.fields has inconsistent visibility_values behavior for the values of built-in select fields

RESOLVED FIXED in Bugzilla 3.6

Status

()

Bugzilla
WebService
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Max Kanat-Alexander, Assigned: Max Kanat-Alexander)

Tracking

Bugzilla 3.6
Bug Flags:
approval +
approval3.6 +
blocking3.6 +

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
For most of the built-in select fields, the "visibility_values" in the "values" items returned by Bug.fields contain a single undef (which doesn't make much sense). This wasn't apparent in the XML-RPC interface, since it strips nulls, but it's apparent in JSON-RPC.

However, for bug_status, there's no visibility_values item at all.

We should be consistent--either the item shouldn't appear at all for these fields, or it should appear for all of them and be empty.
Flags: blocking3.6+
(Assignee)

Comment 1

8 years ago
Created attachment 434456 [details] [diff] [review]
v1

  This makes us return an empty visibility_value array consistently for all these fields.
Assignee: webservice → mkanat
Status: NEW → ASSIGNED
Attachment #434456 - Flags: review?(dkl)
Comment on attachment 434456 [details] [diff] [review]
v1

Looks good and works as described. r=dkl
Attachment #434456 - Flags: review?(dkl) → review+

Updated

8 years ago
Flags: approval?
Flags: approval3.6?
(Assignee)

Updated

8 years ago
Flags: approval?
Flags: approval3.6?
Flags: approval3.6+
Flags: approval+
(Assignee)

Comment 3

8 years ago
  I had to fix some minor bitrot on checkin (because of another patch that I just checked in--I actually expected the bitrot, and it was totally minor).

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/WebService/Bug.pm
Committed revision 7090.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/
modified Bugzilla/WebService/Bug.pm
Committed revision 7052.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.