Closed
Bug 554692
Opened 14 years ago
Closed 14 years ago
Integrate Maemo Geolocation provider
Categories
(Core :: DOM: Geolocation, defect)
Core
DOM: Geolocation
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a4
Tracking | Status | |
---|---|---|
status1.9.2 | --- | .4-fixed |
People
(Reporter: dougt, Assigned: dougt)
Details
Attachments
(1 file)
19.84 KB,
patch
|
dougt
:
review+
romaxa
:
review+
pavlov
:
approval1.9.2.4+
|
Details | Diff | Splinter Review |
Maemo supports geolocation via liblocation. We should support this to be able to get cell/gps/wifi positioning.
Assignee | ||
Comment 1•14 years ago
|
||
This code basically has been moved from: http://hg.mozilla.org/users/romaxa_gmail.com/maemo-geolocation/ to a patch to m-c. I also made some minor cleanups for nits I had.
Assignee: nobody → dougt
Attachment #434597 -
Flags: review+
Assignee | ||
Comment 2•14 years ago
|
||
Comment on attachment 434597 [details] [diff] [review] patch v.1 oleg, can you take one more pass over this to make sure that you are happy with the changes I made.
Attachment #434597 -
Flags: review?(romaxa)
Updated•14 years ago
|
Attachment #434597 -
Flags: review?(romaxa) → review+
Comment 3•14 years ago
|
||
Comment on attachment 434597 [details] [diff] [review] patch v.1 >+ >+ PKG_CHECK_MODULES(LIBLOCATION,liblocation, _LIB_FOUND=1, _LIB_FOUND=) ^ seems here should be some space... >+ MOZ_PLATFORM_MAEMO_LIBS="$MOZ_PLATFORM_MAEMO_LIBS $LIBLOCATION_LIBS" >+ MOZ_PLATFORM_MAEMO_CFLAGS="$MOZ_PLATFORM_MAEMO_CFLAGS $LIBLOCATION_CFLAGS" >+ if test -z "$_LIB_FOUND"; then >+ AC_MSG_ERROR([liblocation is required when building for Maemo]) I'm not sure that liblocation and geolocation is "must be" installed for maemo... Can we make it so that if it is installed, then we use it, otherwise it will skip this component... or make some config option... But in general it looks ok >+ fi > fi
Assignee | ||
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/11d951c99c0f
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Target Milestone: --- → mozilla1.9.3a4
Assignee | ||
Comment 5•14 years ago
|
||
backed out due to compiler error on old sdks.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 6•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/e17283629aa8 removed bits that dealt with interval setting. When we move over to fremantle, we can readdress.
Status: REOPENED → RESOLVED
tracking-fennec: --- → ?
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Attachment #434597 -
Flags: approval1.9.2.4+
Comment 7•14 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/1a9c3eed5fe1
status1.9.2:
--- → .4-fixed
Updated•10 years ago
|
tracking-fennec: ? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•