Closed Bug 554692 Opened 14 years ago Closed 14 years ago

Integrate Maemo Geolocation provider

Categories

(Core :: DOM: Geolocation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a4
Tracking Status
status1.9.2 --- .4-fixed

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(1 file)

Maemo supports geolocation via liblocation.  We should support this to be able to get cell/gps/wifi positioning.
Attached patch patch v.1Splinter Review
This code basically has been moved from:

http://hg.mozilla.org/users/romaxa_gmail.com/maemo-geolocation/

to a patch to m-c.

I also made some minor cleanups for nits I had.
Assignee: nobody → dougt
Attachment #434597 - Flags: review+
Comment on attachment 434597 [details] [diff] [review]
patch v.1

oleg, can you take one more pass over this to make sure that you are happy with the changes I made.
Attachment #434597 - Flags: review?(romaxa)
Attachment #434597 - Flags: review?(romaxa) → review+
Comment on attachment 434597 [details] [diff] [review]
patch v.1


>+
>+      PKG_CHECK_MODULES(LIBLOCATION,liblocation, _LIB_FOUND=1, _LIB_FOUND=)
                                      ^ seems here should be some space...

>+      MOZ_PLATFORM_MAEMO_LIBS="$MOZ_PLATFORM_MAEMO_LIBS $LIBLOCATION_LIBS"
>+      MOZ_PLATFORM_MAEMO_CFLAGS="$MOZ_PLATFORM_MAEMO_CFLAGS $LIBLOCATION_CFLAGS"
>+      if test -z "$_LIB_FOUND"; then
>+         AC_MSG_ERROR([liblocation is required when building for Maemo])

I'm not sure that liblocation and geolocation is "must be" installed for maemo...
Can we make it so that if it is installed, then we use it, otherwise it will skip this component... or make some config option...

But in general it looks ok

>+      fi
>    fi
http://hg.mozilla.org/mozilla-central/rev/11d951c99c0f
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a4
backed out due to compiler error on old sdks.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
http://hg.mozilla.org/mozilla-central/rev/e17283629aa8

removed bits that dealt with interval setting.  When we move over to fremantle, we can readdress.
Status: REOPENED → RESOLVED
tracking-fennec: --- → ?
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
Attachment #434597 - Flags: approval1.9.2.4+
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: