Closed Bug 554693 Opened 12 years ago Closed 12 years ago

Implement stub for indexedDB

Categories

(Core :: Storage: IndexedDB, defect)

defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: sdwilsh, Assigned: sdwilsh)

Details

Attachments

(1 file)

Attached patch v1.0Splinter Review
This implements a stub for indexedDB.  This is largely boilerplate stuff with a test.  This adds zero functionality, however.
Attachment #434600 - Flags: superreview?(vladimir)
Attachment #434600 - Flags: review?(honzab.moz)
Whiteboard: [needs review mayhemer][needs sr vlad]
Comment on attachment 434600 [details] [diff] [review]
v1.0

nsGlobalWindow::GetIndexedDB should fill the result with NULL.

Shouldn't nsIIndexedDatabaseRequest be called nsIDOMIndexedDatabaseRequest to be consistent?  We have DOM prefix on all interfaces (what is imho unnecessary).
(In reply to comment #1)
> (From update of attachment 434600 [details] [diff] [review])
> nsGlobalWindow::GetIndexedDB should fill the result with NULL.
XPCOM rules say I shouldn't have to worry about that AFAIK, and I'm not sure it really matters since this won't land on mozilla-central until I actually implement it.  I can do that if you want still though.

> Shouldn't nsIIndexedDatabaseRequest be called nsIDOMIndexedDatabaseRequest to
> be consistent?  We have DOM prefix on all interfaces (what is imho
> unnecessary).
Yeah, I was torn as what to do.  I thought DOM was only on the other ones because they are part of DOM storage, but maybe I was wrong.  Should we see what sr says?
Comment on attachment 434600 [details] [diff] [review]
v1.0

OK then.  I think that if vlad won't confirm my objects then we can go forward with this.

If it would happen that you land this then I would still set the result of GetIndexedDB to null because you return NS_OK.
Attachment #434600 - Flags: review?(honzab.moz) → review+
Whiteboard: [needs review mayhemer][needs sr vlad] → [needs sr vlad]
Attachment #434600 - Flags: superreview?(vladimir) → superreview+
Comment on attachment 434600 [details] [diff] [review]
v1.0

Let's go without DOM; it looks cleaner.  We can always rename it later if we need to.
Whiteboard: [needs sr vlad]
Blocks: 555317
This has changed, and we aren't going to be doing lots of small bugs anymore...
No longer blocks: async-IndexedDB, 555317
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → INVALID
Whiteboard: [landed-idb]
Component: DOM: Core & HTML → DOM: IndexedDB
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.