554693 - Implement stub for indexedDB

Status: RESOLVED INVALID

(Core :: Storage: IndexedDB, defect)

Description

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

This implements a stub for indexedDB.  This is largely boilerplate stuff with a test.  This adds zero functionality, however.

Comment 1

[Honza Bambas (:mayhemer)]

Comment on attachment 434600 [details] [diff] [review]
v1.0

nsGlobalWindow::GetIndexedDB should fill the result with NULL.

Shouldn't nsIIndexedDatabaseRequest be called nsIDOMIndexedDatabaseRequest to be consistent?  We have DOM prefix on all interfaces (what is imho unnecessary).

Comment 2

[Shawn Wilsher :sdwilsh]

(In reply to comment #1)
> (From update of attachment 434600 [details] [diff] [review])
> nsGlobalWindow::GetIndexedDB should fill the result with NULL.
XPCOM rules say I shouldn't have to worry about that AFAIK, and I'm not sure it really matters since this won't land on mozilla-central until I actually implement it.  I can do that if you want still though.

> Shouldn't nsIIndexedDatabaseRequest be called nsIDOMIndexedDatabaseRequest to
> be consistent?  We have DOM prefix on all interfaces (what is imho
> unnecessary).
Yeah, I was torn as what to do.  I thought DOM was only on the other ones because they are part of DOM storage, but maybe I was wrong.  Should we see what sr says?

Comment 3

[Honza Bambas (:mayhemer)]

Comment on attachment 434600 [details] [diff] [review]
v1.0

OK then.  I think that if vlad won't confirm my objects then we can go forward with this.

If it would happen that you land this then I would still set the result of GetIndexedDB to null because you return NS_OK.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 434600 [details] [diff] [review]
v1.0

Let's go without DOM; it looks cleaner.  We can always rename it later if we need to.

Comment 5

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/users/sdwilsh_shawnwilsher.com/IndexedDB/rev/669f7ab62543

Comment 6

[Shawn Wilsher :sdwilsh]

This has changed, and we aren't going to be doing lots of small bugs anymore...