If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Implement stub for indexedDB

RESOLVED INVALID

Status

()

Core
DOM: IndexedDB
RESOLVED INVALID
8 years ago
6 years ago

People

(Reporter: sdwilsh, Assigned: sdwilsh)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 434600 [details] [diff] [review]
v1.0

This implements a stub for indexedDB.  This is largely boilerplate stuff with a test.  This adds zero functionality, however.
Attachment #434600 - Flags: superreview?(vladimir)
Attachment #434600 - Flags: review?(honzab.moz)
(Assignee)

Updated

8 years ago
Blocks: 553413
(Assignee)

Updated

8 years ago
Whiteboard: [needs review mayhemer][needs sr vlad]
Comment on attachment 434600 [details] [diff] [review]
v1.0

nsGlobalWindow::GetIndexedDB should fill the result with NULL.

Shouldn't nsIIndexedDatabaseRequest be called nsIDOMIndexedDatabaseRequest to be consistent?  We have DOM prefix on all interfaces (what is imho unnecessary).
(Assignee)

Comment 2

8 years ago
(In reply to comment #1)
> (From update of attachment 434600 [details] [diff] [review])
> nsGlobalWindow::GetIndexedDB should fill the result with NULL.
XPCOM rules say I shouldn't have to worry about that AFAIK, and I'm not sure it really matters since this won't land on mozilla-central until I actually implement it.  I can do that if you want still though.

> Shouldn't nsIIndexedDatabaseRequest be called nsIDOMIndexedDatabaseRequest to
> be consistent?  We have DOM prefix on all interfaces (what is imho
> unnecessary).
Yeah, I was torn as what to do.  I thought DOM was only on the other ones because they are part of DOM storage, but maybe I was wrong.  Should we see what sr says?
Comment on attachment 434600 [details] [diff] [review]
v1.0

OK then.  I think that if vlad won't confirm my objects then we can go forward with this.

If it would happen that you land this then I would still set the result of GetIndexedDB to null because you return NS_OK.
Attachment #434600 - Flags: review?(honzab.moz) → review+
Whiteboard: [needs review mayhemer][needs sr vlad] → [needs sr vlad]
Attachment #434600 - Flags: superreview?(vladimir) → superreview+
Comment on attachment 434600 [details] [diff] [review]
v1.0

Let's go without DOM; it looks cleaner.  We can always rename it later if we need to.
(Assignee)

Updated

8 years ago
Whiteboard: [needs sr vlad]
(Assignee)

Updated

8 years ago
Blocks: 555317
(Assignee)

Comment 5

8 years ago
http://hg.mozilla.org/users/sdwilsh_shawnwilsher.com/IndexedDB/rev/669f7ab62543
Whiteboard: [landed-idb]
(Assignee)

Comment 6

7 years ago
This has changed, and we aren't going to be doing lots of small bugs anymore...
No longer blocks: 553413, 555317
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → INVALID
Whiteboard: [landed-idb]
Component: DOM: Core & HTML → DOM: IndexedDB
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.