554696 - KeyError: 'users' in user_link (I think) on add-on detail page

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Jeff Balogh (:jbalogh)]

Traceback (most recent call last):

 File "/data/virtualenvs/zamboni/lib/python2.6/site-packages/django/core/handlers/base.py", line 101, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/amo_python/www/prod/zamboni/apps/addons/views.py", line 27, in decorated
   return f(request, *args, **kwargs)

 File "/data/amo_python/www/prod/zamboni/apps/addons/views.py", line 97, in addon_detail
   return jingo.render(request, 'addons/details.html', data)

 File "/data/virtualenvs/zamboni/lib/python2.6/site-packages/jingo/__init__.py", line 59, in render
   rendered = render_to_string(request, template, context)

 File "/data/virtualenvs/zamboni/lib/python2.6/site-packages/jingo/__init__.py", line 77, in render_to_string
   return template.render(**context)

 File "/data/virtualenvs/zamboni/lib/python2.6/site-packages/jinja2/environment.py", line 705, in render
   return self.environment.handle_exception(exc_info, True)

 File "/data/amo_python/www/prod/zamboni/apps/addons/templates/addons/details.html", line 1, in top-level template code
   {% extends "base.html" %}

 File "/data/amo_python/www/prod/zamboni/templates/base.html", line 59, in top-level template code
   {% block main_content %}

 File "/data/amo_python/www/prod/zamboni/templates/base.html", line 66, in block "main_content"
   {% block content %}{% endblock %}

 File "/data/amo_python/www/prod/zamboni/apps/addons/templates/addons/details.html", line 182, in block "content"
   {% trans user=review.user|user_link, date=review.created|datetime %}

 File "/data/virtualenvs/zamboni/lib/python2.6/site-packages/jinja2/utils.py", line 399, in __mod__
   return self.__class__(unicode.__mod__(self, arg))

 File "/data/virtualenvs/zamboni/lib/python2.6/site-packages/jinja2/utils.py", line 513, in <lambda>
   __getitem__ = lambda s, x: _MarkupEscapeHelper(s.obj[x])

KeyError: u'users'

Comment 1

[Fred Wenzel [:wenzel]]

I can only oracle where this KeyError is supposed to be happening, but I am assuming this is about a review that magically does not have an author (?). I made both user_link and users_list gracefully handle empty input, and added a test: http://github.com/jbalogh/zamboni/commit/9bbb772e3c54305a78686e4f4d0ee165dcd43436 -- I assume that'll fix it.