Closed
Bug 554756
Opened 15 years ago
Closed 15 years ago
Buildbot unexpected passes (with no failures) should be a buildbot warning and not failure
Categories
(Tamarin Graveyard :: Tools, defect)
Tracking
(Not tracked)
VERIFIED
INVALID
People
(Reporter: cpeyer, Unassigned)
Details
Right now any unexpected passes are treated as failures by the buildbot. It seems to me like we should treat that as a warning. Warnings should be treated the same way as failures (in that they should be fixed asap) but it would enable us to differentiate when looking at the buildbot waterfall and emails.
Flags: flashplayer-qrb?
| Reporter | ||
Updated•15 years ago
|
Summary: Buildbot unexpected passes (with no failures) should be a buildbot warining and not failure → Buildbot unexpected passes (with no failures) should be a buildbot warning and not failure
Comment 1•15 years ago
|
||
I think I disagree with that. An unexpected pass means you have made a change to the code but it has an unexpected effect, and we want that to be attended to immediately. (If the effect were expected you would have changed testconfig.txt.)
In general, "warnings" are not a good idea because we get sloppy and let them proliferate, and then we have a hundred of them and then we have less information than we want - new warnings will be lost in the ones we already have.
This is why it's often a good idea to compile with treat-warnings-as-errors, and many teams do.
| Reporter | ||
Comment 2•15 years ago
|
||
Fair enough. Will leave as is.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → INVALID
Updated•14 years ago
|
Flags: flashplayer-qrb?
You need to log in
before you can comment on or make changes to this bug.
Description
•