554809 - The drop indicator is not centered when dragging tabs along the tab bar

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Mehmet]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; de; rv:1.9.2.2) Gecko/20100316 Firefox/3.6.2
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; de; rv:1.9.2.2) Gecko/20100316 Firefox/3.6.2

Hello,

the drop indicator is not centered when dragging tabs along the tab bar.

Thanks and regards
Mehmet

Reproducible: Always

Steps to Reproduce:
1. Open a window with some tabs
2. Rearrange a tab
Actual Results:  
The drop indicator is not centered when dragging tabs along the tab bar.

Expected Results:  
The drop indicator should be centered.

Comment 1

[Mehmet]

Attachment: Screenshot

Screenshot: Minefield compared with Firefox 3.6.2

Comment 2

[Timothy Nikkel (:tnikkel)]

I didn't see this on Windows.

Comment 3

[Brian Carpenter [:geeknik]]

Attachment: Screenshot

Doesn't look centered to me. Win7 Pro x64, Minefield nightly build 20100324040325.

Comment 4

[Timothy Nikkel (:tnikkel)]

I guess it doesn't show up with the windows classic theme then.

Comment 5

[Brian Carpenter [:geeknik]]

Attachment: Screenshot #2

Default theme, same version of Minefield, same OS. Removed the StumbleUpon toolbar and the Personal Toolbar. Still not centered.

Comment 6

[Timothy Nikkel (:tnikkel)]

The directory I was using to test builds must have had some residual files that don't get overwritten when unzipping causing the difference, because after clearing that directory and trying the same build I can now reproduce. Sorry for the confusion.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Regressed between 100316 and 100317. I believe it's a regression from the fix on bug 347930.

Comment 8

[Dão Gottwald [:dao]]

(In reply to comment #7)
> I believe it's a regression from the fix on bug 347930.

Yes, it's from that bug.

Comment 9

[Dão Gottwald [:dao]]

Attachment: fix

Comment 10

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/e82831cbe8d9

Comment 11

[tabmix.onemen]

with this fix when tab bar doesn't overflow you can not drop tab all the way to the left.

when ever we drag over the 3px margin the drag indicator disappear

if you bring back -moz-padding-start: 3px;

then you can fix the drag indicator position by (this is for left to right):
add
+ var ibRect = ind.parentNode.getBoundingClientRect();


replace
var minMargin = scrollRect.left - rect.left;
with
var minMargin = scrollRect.left - rect.left - ibRect.left;

replace twice
newMargin = tabRect.right - rect.left;
with
newMargin = tabRect.right - rect.left - ibRect.left;;

Comment 12

[Dão Gottwald [:dao]]

Thanks for letting us know, but can you please file a new bug?