554836 - On idle occurs 'JavaScript component does not have a method named: "onDeleteVisits"'

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Igor Velkov]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a4pre) Gecko/20100322 SeaMonkey/2.1a1pre
Build Identifier: 


Time to time at error console appears message
Error: 'JavaScript component does not have a method named: "onDeleteVisits"' when calling method: [nsINavHistoryObserver::onDeleteVisits] = NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED
Source file: file:///C:/Program%20Files/SeaMonkey/components/nsPlacesExpiration.js
Line: 657


Reproducible: Sometimes

Comment 1

[Brian Carpenter [:geeknik]]

I'm seeing this with the 4/19 nightly build of Minefield:

Error: [Exception... "'JavaScript component does not have a method named: "onDeleteVisits"' when calling method: [nsINavHistoryObserver::onDeleteVisits]"  nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)"  location: "JS frame :: file:///C:/Program%20Files%20(x86)/Minefield/components/nsPlacesExpiration.js :: PEX_handleCompletion :: line 657"  data: no]
Source File: file:///C:/Program%20Files%20(x86)/Minefield/components/nsPlacesExpiration.js
Line: 657

Comment 2

[Marco Bonardo [:mak]]

cool, now we just have to find which object :)
After a quick comparison between onDeleteURI and onDeleteVisits on mxr, i can't find a missing point in our code :(

Any idea if an add-on could be related?

Comment 3

[Brian Carpenter [:geeknik]]

Possibly the Adblock Plus Element Hiding Helper. I've been playing around with my extensions for the last hour or so without the error and when I re-enabled this one, I started seeing it again in the Error Console.

Comment 4

[Marco Bonardo [:mak]]

i can't find related code in that add-on. can i get a list of your enabled add-ons? if you can give me add-on id (the id that they have on AMO) that would be even better

Comment 5

[Brian Carpenter [:geeknik]]

Here is my list, the AMO ID is in parentheses. 

AdBlock Plus v1.1.3+.2010041702 (dev version from author's site)
AdBlock Plus: Element Hiding Helper 1.0.6 (4364)
Craigslist Image Prefetcher 1.1.7 (12544)
Gmail Manager 0.6.1 (1320)
Greasemonkey 0.8.20100408.6 (748)
Imgur Uploader 0.3 (14389)
Live Pagerank 0.9.7 (2007)
Nightly Tester Tools 2.0.3 (1391)
Open Image In New Tab 1.1 (2248)
StumbleUpon 3.64 (138)
Update Scanner 3.0.8 (3362)
WeatherBug 2.0.0.4 (2455)
Weave Sync 1.2.1 (10868)

Let me know if you need anything else.

Comment 6

[Igor Velkov]

It can be weave.

Comment 7

[Marco Bonardo [:mak]]

ha, it's Weave indeed.

it is still using onPageExpired, i thought i had notified someone of the change :(

https://mxr.mozilla.org/addons/source/10868/modules/engines/history.js#325

Comment 8

[Mike Connor [:mconnor]]

better link http://mxr.mozilla.org/labs-central/source/weave/source/modules/engines/history.js#303

File a bug, don't just poke us on IRC. :)

Comment 9

[Ed Lee :Mardak]

Attachment: v1

Comment 10

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/997a712b8e65
Add onDeleteVisits in addition to onPageExpired to maintain compatibility with old and new API.