554895 - Commands get executed although the command line is not focused

Status: RESOLVED FIXED

(Skywriter Graveyard :: Command Line, defect, P1)

Description

[Julian Viereck]

Commands that are typed but not yet executed get executed if the user hits 
enter on the editor.

Steps to reproduce:
a) set the command lines value to "help", but do *not* execute it
b) focus the editor
c) press enter on the editor

Result: the command "help" is executed.

Tested on Firefox 3.6/Mac.

Comment 1

[Julian Viereck]

This bug seems to be fixed on Firefox...

*But* on Webkit (Chrome + Safari Mac) this bug takes place now. It's even 
worse: enter (newline) is *not* working on these browsers in the editor!

As the newline command is important, I mark this bug as blocker.

Comment 2

[Julian Viereck]

Attachment: Bugfix

Brings newline functionality back again. Handle the return key in the keyDown
function again and not in the textInserted function.

However, why is the newline still reported in the textInserted function?

Comment 3

[Kevin Dangoor]

Is this related to bug 555023?

Comment 4

[Julian Viereck]

Attachment: Bugfix #2

This is based on the first bugfix. You have to apply the SC fixes as described in bug 

   https://bugzilla.mozilla.org/show_bug.cgi?id=555598

before this bugfix works.

Comment 5

[Patrick Walton (:pcwalton)]

Merged and pushed as changeset cdc676ca0fea.