show default CC in editusers.cgi > Product Responsibilities

RESOLVED FIXED in Bugzilla 4.0

Status

()

Bugzilla
Administration
P3
enhancement
RESOLVED FIXED
8 years ago
3 years ago

People

(Reporter: mconnor, Assigned: reed)

Tracking

unspecified
Bugzilla 4.0
Bug Flags:
approval +

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

8 years ago
We show default assignee and default QA there already, we should also show default CC, as this is something that should be visible when checking a user's access.  As CCed people have access, ignoring group controls, this is something that is useful to audit if someone changes roles or leaves an employer.

Updated

8 years ago
Severity: normal → enhancement
OS: Mac OS X → All
Hardware: x86 → All

Comment 1

8 years ago
Yeah, I'm surprised that we don't already do that?
Priority: -- → P1
Whiteboard: [Good Intro Bug]
(Assignee)

Comment 2

8 years ago
Created attachment 452310 [details] [diff] [review]
patch - v1

Untested, so will test first before requesting review.
Assignee: administration → reed
Status: NEW → ASSIGNED
(Assignee)

Updated

8 years ago
Target Milestone: --- → Bugzilla 3.8
(Assignee)

Comment 3

8 years ago
Comment on attachment 452310 [details] [diff] [review]
patch - v1

Works from basic testing.
Attachment #452310 - Flags: review?(mkanat)

Comment 4

8 years ago
Comment on attachment 452310 [details] [diff] [review]
patch - v1

>=== modified file 'Bugzilla/User.pm'
>+        [% FOREACH cc_user = component.initial_cc %]
>+          [% IF cc_user.id == otheruser.id %]
>+            [% is_default_cc = 1 %]
>+            [% LAST %]
>+          [% END %]
>+        [% END %]

  Hmm. Since this is trunk, would you be so kind as to add a contains_object vmethod in Bugzilla::Template that assumes its array and argument are Bugzilla::Object-y? That way we could avoid all this complex code, and we'd probably want it elsewhere anyhow.

  Or just modify contains() to check if its argument is a Bugzilla::Object--that would work too, possible even more cleanly.
Attachment #452310 - Flags: review?(mkanat) → review-
(Assignee)

Comment 5

8 years ago
Created attachment 454416 [details] [diff] [review]
patch - v2
Attachment #452310 - Attachment is obsolete: true
Attachment #454416 - Flags: review?(mkanat)
(Assignee)

Updated

8 years ago
Attachment #454416 - Attachment description: patch - v1 → patch - v2

Updated

8 years ago
Priority: P1 → P3

Comment 6

8 years ago
Comment on attachment 454416 [details] [diff] [review]
patch - v2

Looks great.

In the future, we should modify contains and containsany to be able to combine objects and non-objects and to both use a central function for this) but for now this is great. :-)
Attachment #454416 - Flags: review?(mkanat) → review+

Updated

8 years ago
Flags: approval+
(Assignee)

Comment 7

8 years ago
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Template.pm
modified Bugzilla/User.pm
modified template/en/default/admin/users/responsibilities.html.tmpl
Committed revision 7272.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

7 years ago
Keywords: relnote

Comment 8

7 years ago
Added to the release notes in bug 604256.
Keywords: relnote

Updated

6 years ago
Whiteboard: [Good Intro Bug]

Comment 9

3 years ago
Comment on attachment 454416 [details] [diff] [review]
patch - v2

>=== modified file 'template/en/default/admin/users/responsibilities.html.tmpl'

>+      <th>Default CC</th>

You forgot to update colspan accordingly (3 -> 4).

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   4f59098..a500926  master -> master

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   741201e..d73a35c  5.0 -> 5.0
You need to log in before you can comment on or make changes to this bug.