554964 - show default CC in editusers.cgi > Product Responsibilities

Status: RESOLVED FIXED

(Bugzilla :: Administration, task, P3)

Description

[Mike Connor [:mconnor]]

We show default assignee and default QA there already, we should also show default CC, as this is something that should be visible when checking a user's access.  As CCed people have access, ignoring group controls, this is something that is useful to audit if someone changes roles or leaves an employer.

Comment 1

[Max Kanat-Alexander]

Yeah, I'm surprised that we don't already do that?

Comment 2

[Reed Loden [:reed]]

Attachment: patch - v1

Untested, so will test first before requesting review.

Comment 3

[Reed Loden [:reed]]

Comment on attachment 452310 [details] [diff] [review]
patch - v1

Works from basic testing.

Comment 4

[Max Kanat-Alexander]

Comment on attachment 452310 [details] [diff] [review]
patch - v1

>=== modified file 'Bugzilla/User.pm'
>+        [% FOREACH cc_user = component.initial_cc %]
>+          [% IF cc_user.id == otheruser.id %]
>+            [% is_default_cc = 1 %]
>+            [% LAST %]
>+          [% END %]
>+        [% END %]

  Hmm. Since this is trunk, would you be so kind as to add a contains_object vmethod in Bugzilla::Template that assumes its array and argument are Bugzilla::Object-y? That way we could avoid all this complex code, and we'd probably want it elsewhere anyhow.

  Or just modify contains() to check if its argument is a Bugzilla::Object--that would work too, possible even more cleanly.

Comment 5

[Reed Loden [:reed]]

Attachment: patch - v2

Comment 6

[Max Kanat-Alexander]

Comment on attachment 454416 [details] [diff] [review]
patch - v2

Looks great.

In the future, we should modify contains and containsany to be able to combine objects and non-objects and to both use a central function for this) but for now this is great. :-)

Comment 7

[Reed Loden [:reed]]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Template.pm
modified Bugzilla/User.pm
modified template/en/default/admin/users/responsibilities.html.tmpl
Committed revision 7272.

Comment 8

[Max Kanat-Alexander]

Added to the release notes in bug 604256.

Comment 9

[Frédéric Buclin]

Comment on attachment 454416 [details] [diff] [review]
patch - v2

>=== modified file 'template/en/default/admin/users/responsibilities.html.tmpl'

>+      <th>Default CC</th>

You forgot to update colspan accordingly (3 -> 4).

To ssh://[e-mail]/bugzilla/bugzilla.git
   4f59098..a500926  master -> master

To ssh://[e-mail]/bugzilla/bugzilla.git
   741201e..d73a35c  5.0 -> 5.0