555019 - Need implementation of VKB state (open/closed) for GetIMEEnabled method

Status: RESOLVED WONTFIX

(Core Graveyard :: Widget: Qt, defect)

Description

[Oleg Romashin (:romaxa)]

nsWindow::GetIMEEnabled is not implemented crrectly for Qt, because we don't have right API.

We need to solve this problem.

Comment 1

[Jeremias Bosch (:jbos)]

this is basically a plattform issue for meego / maemo, there is no "general" ime for qt we could refer to.

Comment 2

[Miika Jarvinen]

Attachment: Patch which checks area consumed by vkb on meegotouch build

Added patch, which checks whether input method is visible on screen. This can be only checked when MOZ_ENABLE_MEEGOTOUCH is used, because Qt doesn't have API for this.

Comment 3

[Oleg Romashin (:romaxa)]

Comment on attachment 466702 [details] [diff] [review]
Patch which checks area consumed by vkb on meegotouch build


>+#ifdef MOZ_ENABLE_MEEGOTOUCH
- >+    MInputMethodState *inputState = MInputMethodState::instance();
should be
+ >+    MInputMethodState* inputState = MInputMethodState::instance();
                           
                       
- >+        const QRect &vkbArea = inputState->inputMethodArea();
should be
+ >+        const QRect& vkbArea = inputState->inputMethodArea();

>+        return vkbArea.height() > 5;
here should be !vkbArea.isEmpty(), "> 5" looks like hack
>+    }

Comment 4

[Jeremias Bosch (:jbos)]

I just realize that this is wrong. Its not about the size of the VKB we are talking here. Its about if IME is active or not - which is also true in cases when the VKB is hidden and a Hardware Keyboard is active (just think about real external keyboards with BT).

There is no api to ask if IME is active actually, so lets keep it as it is - with the flag and maybe request an api for this from meego input method framework.