Status

defect
P5
normal
RESOLVED FIXED
9 years ago
3 years ago

People

(Reporter: clouserw, Assigned: jsocol)

Tracking

unspecified
5.10

Details

(Whiteboard: [qa-])

Reporter

Description

9 years ago
We should add the request's IP to the logging.  Make sure we check X_FORWARDED_FOR.  Django should have this built in somewhere, if not, maybe a patch would be appropriate.

P5 for now.  Whoever gets time can do this, or I will eventually.
Django used to have a middleware for this: http://docs.djangoproject.com/en/dev/releases/1.1/#id1
Reporter

Updated

9 years ago
Assignee: nobody → james
Target Milestone: 5.9 → 5.10
Summary: Add IP to loggging → Add IP to logging
Assignee

Comment 2

9 years ago
Here's middleware to replace the old Django middleware.

http://github.com/jsocol/commonware
Reporter

Comment 3

9 years ago
I think that will work, r+.  Replacing REMOTE_ADDR seems fine but I don't think I've seen it before.  Shouldn't matter though.
Assignee

Comment 4

9 years ago
Wil, I followed Django's old method. If you'd rather it do something else, I can change it.
Reporter

Comment 5

9 years ago
I think it'll work fine :)
Reporter

Comment 7

9 years ago
Added some comments on the commit.  r+, thanks
Assignee

Comment 8

9 years ago
http://github.com/jbalogh/zamboni/commit/470e8935a45c73e0f5e768f70cca8041c9f0b104
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.