555069 - Add IP to logging

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Code Quality, defect, P5)

Description

[Wil Clouser [:clouserw]]

We should add the request's IP to the logging.  Make sure we check X_FORWARDED_FOR.  Django should have this built in somewhere, if not, maybe a patch would be appropriate.

P5 for now.  Whoever gets time can do this, or I will eventually.

Comment 1

[Jeff Balogh (:jbalogh)]

Django used to have a middleware for this: http://docs.djangoproject.com/en/dev/releases/1.1/#id1

Comment 2

[James Socol [:jsocol, :james]]

Here's middleware to replace the old Django middleware.

http://github.com/jsocol/commonware

Comment 3

[Wil Clouser [:clouserw]]

I think that will work, r+.  Replacing REMOTE_ADDR seems fine but I don't think I've seen it before.  Shouldn't matter though.

Comment 4

[James Socol [:jsocol, :james]]

Wil, I followed Django's old method. If you'd rather it do something else, I can change it.

Comment 5

[Wil Clouser [:clouserw]]

I think it'll work fine :)

Comment 6

[James Socol [:jsocol, :james]]

r? http://github.com/jsocol/zamboni/commit/17f4259888aafa1ed65739f00f9a582b2b972f67

Also involved updates to commonware: http://github.com/jsocol/commonware

Comment 7

[Wil Clouser [:clouserw]]

Added some comments on the commit.  r+, thanks

Comment 8

[James Socol [:jsocol, :james]]

http://github.com/jbalogh/zamboni/commit/470e8935a45c73e0f5e768f70cca8041c9f0b104