Closed
Bug 555089
Opened 15 years ago
Closed 15 years ago
Add hooks in the messages template to warn the user after updating classification or components custom fields
Categories
(Bugzilla :: Extensions, enhancement)
Bugzilla
Extensions
Tracking
()
RESOLVED
FIXED
Bugzilla 3.6
People
(Reporter: timello, Assigned: timello)
Details
Attachments
(1 file)
|
808 bytes,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
Today if I use a new custom field to Classification or Component and I perform an update in the edit page the message says that no change has been made. That happens because messages.html.tmpl is not considering the new fields.
I'm proposing one new hook for each message_tag = '(classification|component)_updated' entry.
|
Assignee | |
Updated•15 years ago
|
Attachment #435022 -
Flags: review?(mkanat)
|
|
Assignee | |
Comment 1•15 years ago
|
||
Comment on attachment 435022 [details] [diff] [review]
Adds 2 hooks: classification_updated_fields and component_updated_fields.
This patch also adds </ul> which seems to be missing.
|
|
Assignee | |
Updated•15 years ago
|
Assignee: extensions → timello
Status: NEW → ASSIGNED
|
||
Comment 2•15 years ago
|
||
Comment on attachment 435022 [details] [diff] [review]
Adds 2 hooks: classification_updated_fields and component_updated_fields.
Looks good to me!
Attachment #435022 -
Flags: review?(mkanat) → review+
|
|
||
Updated•15 years ago
|
Flags: approval3.6+
Flags: approval+
Target Milestone: --- → Bugzilla 3.6
|
||
Comment 3•15 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/global/messages.html.tmpl
Committed revision 7099.
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.6/
modified template/en/default/global/messages.html.tmpl
Committed revision 7058.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•