If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Add hooks in the messages template to warn the user after updating classification or components custom fields

RESOLVED FIXED in Bugzilla 3.6

Status

()

Bugzilla
Extensions
--
enhancement
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: timello, Assigned: timello)

Tracking

unspecified
Bugzilla 3.6
Bug Flags:
approval +
approval3.6 +

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 435022 [details] [diff] [review]
Adds 2 hooks: classification_updated_fields and component_updated_fields.

Today if I use a new custom field to Classification or Component and I perform an update in the edit page the message says that no change has been made. That happens because messages.html.tmpl is not considering the new fields.

I'm proposing one new hook for each message_tag = '(classification|component)_updated' entry.
(Assignee)

Updated

8 years ago
Attachment #435022 - Flags: review?(mkanat)
(Assignee)

Comment 1

8 years ago
Comment on attachment 435022 [details] [diff] [review]
Adds 2 hooks: classification_updated_fields and component_updated_fields.

This patch also adds </ul> which seems to be missing.
(Assignee)

Updated

8 years ago
Assignee: extensions → timello
Status: NEW → ASSIGNED

Comment 2

8 years ago
Comment on attachment 435022 [details] [diff] [review]
Adds 2 hooks: classification_updated_fields and component_updated_fields.

Looks good to me!
Attachment #435022 - Flags: review?(mkanat) → review+

Updated

8 years ago
Flags: approval3.6+
Flags: approval+
Target Milestone: --- → Bugzilla 3.6

Comment 3

8 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/global/messages.html.tmpl
Committed revision 7099.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.6/
modified template/en/default/global/messages.html.tmpl
Committed revision 7058.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.