555224 - Page is repainted to default zoom level after open a link in new tab/middle-click.

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US;
                  rv:1.9.3a4pre) Gecko/20100326 Minefield/3.7a4pre ID:20100326040105
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US;
                  rv:1.9.3a4pre) Gecko/20100326 Minefield/3.7a4pre ID:20100326040105

Page is repainted to default level after open a link in new tab.

Reproducible: Always

Steps to Reproduce:
1. Start Minefield with new profile
2. Open any page
3. Zoom in (Ctrl + Ctrl + Ctrl + Ctrl + )
4. Open a link in new background tab (Middle click a link)

Actual Results:
 Page is repainted to default zoom level.

Expected Results:
 Page should not be repainted.
 and should  keep zoom level.

Comment 1

[Alice0775 White]

the following seems to fix the issue .
In FullZoom.onLocationChange in browser.js

    // Avoid the cps roundtrip and apply the default/global pref.
    if (aURI.spec == "about:blank") {
-      this._applyPrefToSetting();
+      this._applyPrefToSetting(undefined , aBrowser);
      return;
    }

Comment 2

[DB Cooper]

Can confirm that this is always reproducible. Using win7 64it, build details below:

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100326 Minefield/3.7a4pre ID:20100326040105

Comment 3

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Patch

Doh. onLocationChange gives us the background browser for this case while calling _applyPrefToSetting with both parameters undefined acts on the foreground browser...

Comment 5

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Pushed with r=dtownsend over IRC.
http://hg.mozilla.org/mozilla-central/rev/cf17c30f39b7

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 435357 [details] [diff] [review]
Patch

As it's already been reviewed, it no longer needs my review, so cancelling the request.

Sorry I didn't get to this before you found review elsewhere! :-/