555486 - Add information to the API about where add-ons are installed

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Dave Townsend [:mossop]]

Going to group add-ons into the following general install areas:

Application
System
User
Profile

Comment 1

[Dave Townsend [:mossop]]

Fixed in http://hg.mozilla.org/projects/addonsmgr/rev/789c015728d8

Comment 2

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Adds an Addon.scope property that holds the area an add-on is installed in. Also allows disabling certain scopes and disables the application scope for xpcshell tests which should stop issues with SeaMonkey etc.

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 435778 [details] [diff] [review]
patch rev 1

It looks like you aren't turning off the registry install location by default for xpcshell which isn't really a problem as I see it but since we discussed it I am bringing it up.

Is it possible to reload the extensions for mochitests using this method?

>diff --git a/toolkit/mozapps/extensions/AddonManager.jsm b/toolkit/mozapps/extensions/AddonManager.jsm
>--- a/toolkit/mozapps/extensions/AddonManager.jsm
>+++ b/toolkit/mozapps/extensions/AddonManager.jsm
>@@ -825,6 +825,16 @@ var AddonManager = {
>   // Indicates that the Addon can be upgraded.
>   PERM_CAN_UPGRADE: 8,
> 
>+  // General descriptions of where items are installed.
>+  // Installed in this profile.
>+  SCOPE_PROFILE: 1,
>+  // Installed and owned by the application.
>+  SCOPE_APPLICATION: 2,
>+  // Installed for all of this user's profiles.
>+  SCOPE_USER: 4,
>+  // Installed for all users of the computer.
>+  SCOPE_SYSTEM: 8,
Might be handy to have a SCOPE_ALL here

>   getInstallForURL: function AM_getInstallForURL(url, callback, mimetype, hash,
>                                                  name, iconURL, version,
>                                                  loadGroup) {
>diff --git a/toolkit/mozapps/extensions/XPIProvider.jsm b/toolkit/mozapps/extensions/XPIProvider.jsm
>--- a/toolkit/mozapps/extensions/XPIProvider.jsm
>+++ b/toolkit/mozapps/extensions/XPIProvider.jsm
>...
>@@ -811,16 +812,44 @@ var XPIProvider = {
> 
>     let hasRegistry = ("nsIWindowsRegKey" in Ci);
> 
>+    let enabledScopes = Prefs.getIntPref(PREF_EM_ENABLED_SCOPES, 15);
and use SCOPE_ALL here

>...
>@@ -4397,6 +4437,20 @@ DirectoryInstallLocation.prototype = {
>   },
> 
>   /**
>+   * Gets the scope of this install location.
>+   */
>+  get scope() {
>+    return this._scope;
>+  },
>+
>+  /**
>+   * Gets the scope of this install location.
>+   */
>+  get scope() {
>+    return this._scope;
>+  },
Two get scope()'s

I'd prefer reviewing a new patch with the fixes above and against the changes from bug 555083 so r-. The tests look good so it shouldn't take long to finish the review for this.

Comment 4

[Dave Townsend [:mossop]]

Attachment: patch rev 2

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 437326 [details] [diff] [review]
patch rev 2

Looks good

Comment 6

[Dave Townsend [:mossop]]

http://hg.mozilla.org/mozilla-central/rev/98501168f5fe

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed by check-in and passing automated tests.

Comment 8

[Dave Townsend [:mossop]]

Do we document preferences? If so we should document extensions.enabledScopes, particularly the fact that you can't turn off the profile scope.

Comment 9

[Eric Shepherd [:sheppy]]

Added a note about the extensions.enabledScopes preference here:

https://developer.mozilla.org/en/Addons/Add-on_Manager/AddonManager#Installation_scopes

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Eric Shepherd [:sheppy] from comment #9)
> https://developer.mozilla.org/en/Addons/Add-on_Manager/
> AddonManager#Installation_scopes

Those scopes are not correct. The list of current values can be found here:
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/AddonManager.jsm#1258

Comment 11

[Eric Shepherd [:sheppy]]

(In reply to Henrik Skupin (:whimboo) from comment #10)
> (In reply to Eric Shepherd [:sheppy] from comment #9)
> > https://developer.mozilla.org/en/Addons/Add-on_Manager/
> > AddonManager#Installation_scopes
> 
> Those scopes are not correct. The list of current values can be found here:
> http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/
> AddonManager.jsm#1258

They look exactly the same to me, they're just sorted into alphabetical order. I added the values of the constants to the table though.