555509 - Clicking disable or enable in the detail view doesn't update the UI

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Dave Townsend [:mossop]]

If I go to the detail view of an add-on and click disable/enable nothing appears to happen. Going back to the list shows the change and an ugly progress-bar-like-thing.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Dave, can you attach a screenshot?

Comment 2

[Dave Townsend [:mossop]]

Attachment: screenshot

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Dave. That's already handled in bug 554245.

Comment 4

[Dave Townsend [:mossop]]

Bug 554245 makes no mention of the disable/enable button having no effect in the list view. That is the main issue here.

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

http://hg.mozilla.org/projects/addonsmgr/rev/24f4f87cb241

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #0)
> If I go to the detail view of an add-on and click disable/enable nothing
> appears to happen. Going back to the list shows the change and an ugly
> progress-bar-like-thing.

The broken status image is still present. I have filed bug 561982.

Comment 7

[Dave Townsend [:mossop]]

Landed on trunk as a part of bug 554007

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I think that should be part of a broader test. I will create Litmus tests for all panes which will also cover this part. What about automation?

Verified fixed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100514 Minefield/3.7a5pre

Comment 9

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Yea, can be automated too. I think.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #9)
> Yea, can be automated too. I think.

Blair, is that already covered meanwhile by an automated test?

Comment 11

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Covered in existing tests browser_list.js and browser_details.js - no need for a litmus test, IMO.