555562 - remove xpctools as no maintainer in 3 years

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jory A. Pratt [:anarchy]]

Attachment: xpctools-removal.diff

Simple remove the xpctools support, it is broken in latest trunk again and no maintainer. This completely removes the xpctools code from all parts of the tree.

Comment 1

[Jory A. Pratt [:anarchy]]

reed if you could please assign for proper review would be appreciated, I would like to see this landed soon as I I just reviewed the 1.9.2 branch and it is still busted as well refer to bug #517784

Comment 2

[Reed Loden [:reed]]

Comment on attachment 435470 [details] [diff] [review]
xpctools-removal.diff

> dnl   Seth Spitzer <[e-mail]>
>-dnl   xpctools support

This removal is wrong.

Trying shaver/timeless for review...

Comment 3

[(not currently active) Ted Mielczarek]

FWIW, the configure+Makefile changes look fine. I think you missed a spot though:
http://mxr.mozilla.org/mozilla-central/source/js/src/xpconnect/src/Makefile.in#160

And presumably then you should remove these bits:
http://mxr.mozilla.org/mozilla-central/search?string=XPC_TOOLS_SUPPORT

Comment 4

[timeless]

darn, i used to use xpctools while i was at cenzic iirc. sadly i've been at nokia for 4 years.

i think i'd kinda prefer to have it working. i half expect people to actively break jsd (which also has a profiler), they've been doing that periodically, whereas xpctools is relatively smaller and thus should be harder for them to break.

i'm currently traveling during a period of holy days, and thus am not really in a position to do much. I will note that I generally respond to requests and have addressed your other bug.

Comment 5

[Jory A. Pratt [:anarchy]]

timeless I am willing to work on fixing this, I am sure I will have questions along the way, but willing to work on the code as time permits. If you would rather keep it let me know and I will see what I can do to provide a fix for current trunk.

Comment 6

[timeless]

yes, let's do that, i'm generally available to help, although this week is full of holy days....

Comment 7

[Mike Shaver (:shaver emeritus)]

Comment on attachment 435470 [details] [diff] [review]
xpctools-removal.diff

Sure, let's clean it up.

Comment 8

[Jory A. Pratt [:anarchy]]

Attachment: xpctools-removal-v2

Shaver I have updated with teds comments, I also removed the bits of xpctools dnl not sure how to properly handle that part of both configure.in files. If you need me for anything else with this let me know and I will work out some time to finish up.

Comment 9

[Mike Shaver (:shaver emeritus)]

Comment on attachment 444811 [details] [diff] [review]
xpctools-removal-v2

Looks good.  Rebuilding this functionality from scratch atop JSDv2 will be easier than rebuilding the ship at sea.

Comment 10

[Jory A. Pratt [:anarchy]]

On 12/05/2010 12:42 AM, Jory A. Pratt wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Sorry to bother you Shaver, should I reopen and schedule for checkin?
> Please advise on how you would prefer to handle this.

Yeah, that's probably the best plan.

Mike

Comment 11

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/1808e7d6807f