Closed Bug 555562 Opened 12 years ago Closed 12 years ago

remove xpctools as no maintainer in 3 years

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.3a5

People

(Reporter: anarchy, Assigned: anarchy)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch xpctools-removal.diff (obsolete) — Splinter Review
Simple remove the xpctools support, it is broken in latest trunk again and no maintainer. This completely removes the xpctools code from all parts of the tree.
Attachment #435470 - Attachment is patch: true
reed if you could please assign for proper review would be appreciated, I would like to see this landed soon as I I just reviewed the 1.9.2 branch and it is still busted as well refer to bug #517784
Comment on attachment 435470 [details] [diff] [review]
xpctools-removal.diff

> dnl   Seth Spitzer <sspitzer@netscape.com>
>-dnl   xpctools support

This removal is wrong.

Trying shaver/timeless for review...
Attachment #435470 - Flags: review?(timeless)
Attachment #435470 - Flags: review?(shaver)
FWIW, the configure+Makefile changes look fine. I think you missed a spot though:
http://mxr.mozilla.org/mozilla-central/source/js/src/xpconnect/src/Makefile.in#160

And presumably then you should remove these bits:
http://mxr.mozilla.org/mozilla-central/search?string=XPC_TOOLS_SUPPORT
Assignee: nobody → anarchy
darn, i used to use xpctools while i was at cenzic iirc. sadly i've been at nokia for 4 years.

i think i'd kinda prefer to have it working. i half expect people to actively break jsd (which also has a profiler), they've been doing that periodically, whereas xpctools is relatively smaller and thus should be harder for them to break.

i'm currently traveling during a period of holy days, and thus am not really in a position to do much. I will note that I generally respond to requests and have addressed your other bug.
timeless I am willing to work on fixing this, I am sure I will have questions along the way, but willing to work on the code as time permits. If you would rather keep it let me know and I will see what I can do to provide a fix for current trunk.
yes, let's do that, i'm generally available to help, although this week is full of holy days....
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
Comment on attachment 435470 [details] [diff] [review]
xpctools-removal.diff

Sure, let's clean it up.
Attachment #435470 - Flags: review?(timeless)
Attachment #435470 - Flags: review?(shaver)
Attachment #435470 - Flags: review+
Shaver I have updated with teds comments, I also removed the bits of xpctools dnl not sure how to properly handle that part of both configure.in files. If you need me for anything else with this let me know and I will work out some time to finish up.
Attachment #435470 - Attachment is obsolete: true
Attachment #444811 - Flags: review?(shaver)
Comment on attachment 444811 [details] [diff] [review]
xpctools-removal-v2

Looks good.  Rebuilding this functionality from scratch atop JSDv2 will be easier than rebuilding the ship at sea.
Attachment #444811 - Flags: review?(shaver) → review+
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
On 12/05/2010 12:42 AM, Jory A. Pratt wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Sorry to bother you Shaver, should I reopen and schedule for checkin?
> Please advise on how you would prefer to handle this.

Yeah, that's probably the best plan.

Mike
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/1808e7d6807f
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.