555573 - [e10s] IPDL generates code which may not compile on Windows

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

I'm not quite sure what goes wrong with
typedefs, namespaces, classes and/or usings but Bug 554941
creates code which gives errors on Windows

e:/builds/moz2_slave/electrolysis-win32-debug/build/obj-firefox/ipc/ipdl/PIFrameEmbeddingChild.cpp(329)
: error C2872: 'PContextWrapperChild' : ambiguous symbol
        could be
'e:/builds/moz2_slave/electrolysis-win32-debug/build/obj-firefox/ipc/ipdl/PIFrameEmbeddingChild.cpp(22)
: mozilla::jsipc::PContextWrapperChild PContextWrapperChild'
        or
'e:\builds\moz2_slave\electrolysis-win32-debug\build\obj-firefox\ipc\ipdl\_ipdlheaders\mozilla/jsipc/PContextWrapperChild.h(59)
: mozilla::jsipc::PContextWrapperChild'
e:/builds/moz2_slave/electrolysis-win32-debug/build/obj-firefox/ipc/ipdl/PIFrameEmbeddingChild.cpp(335)
: error C2872: 'PContextWrapperChild' : ambiguous symbol
        could be
'e:/builds/moz2_slave/electrolysis-win32-debug/build/obj-firefox/ipc/ipdl/PIFrameEmbeddingChild.cpp(22)
: mozilla::jsipc::PContextWrapperChild PContextWrapperChild'
        or
'e:\builds\moz2_slave\electrolysis-win32-debug\build\obj-firefox\ipc\ipdl\_ipdlheaders\mozilla/jsipc/PContextWrapperChild.h(59)
: mozilla::jsipc::PContextWrapperChild'

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

I don't quite understand why the
generated code is like typedef mozilla::jsipc::PContextWrapperChild PContextWrapperChild;
and not perhaps
using mozilla::jsipc::PContextWrapperChild;
That might help with the problem, or might not. I don't have Windows development environment atm to test.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

cjones, would be great if you could look at the problem.
I'm hoping to get bug 554941 fixed this Q.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: wip

Something like this might help.
Well, at least the code compiles on Linux. Haven't tried on Windows.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 435578 [details] [diff] [review]
wip

Based on tryserver this works on Windows, well at least everything compiles.

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 435578 [details] [diff] [review]
wip

>diff --git a/ipc/ipdl/ipdl/cxx/ast.py b/ipc/ipdl/ipdl/cxx/ast.py
>--- a/ipc/ipdl/ipdl/cxx/ast.py
>+++ b/ipc/ipdl/ipdl/cxx/ast.py
>+class Using(Node):
>+    def __init__(self, longtypename):
>+        Node.__init__(self)
>+        self.longtypename = longtypename
>+

Nit: s/longtypename/type/.

I don't really understand this error, or why we haven't seen it before, but this change looks OK if it fixes things.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: +comments

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/projects/electrolysis/rev/74307b5f672b

Comment 8

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

http://hg.mozilla.org/mozilla-central/rev/f8e5a7f4450a