[test] Remove Litmus meta data from Mozmill tests

RESOLVED FIXED

Status

RESOLVED FIXED
9 years ago
2 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Details

Attachments

(2 attachments, 6 obsolete attachments)

We put the Litmus meta data into all of our tests because we wanted to sync the results from Brasstacks with Litmus. Seeing the reality we will never have such a script. No-one will have time to work on it. Also when we have a green test-run we could simply use a bookmarklet on Litmus to automatically mark all the tests as passed. That should be a trivial task.

The work which is required from us to keep track of the Litmus id in our tests doesn't correlate to it's usefulness. That's why we wanna remove those lines from all tests in the default and mozilla1.9.1 branch. 

Is anyone familiar with sed and can create a helpful regex to remove those lines automatically? 

This is an example:

> /**
>  * Map test functions to litmus tests
>  */
> testPermissionsDisabled.meta = {litmusids : [7397]};
Assigning to myself.  I spoke with Matt about this and he actually just wants the lines commented out.  This will be a lot easier than removing the 4 lines. :)
Assignee: nobody → anthony.s.hughes
After some research, I've come up with the following command:
grep -B 1 -A 2 -lr -e 'litmusids : ' ./firefox | xargs sed -i '$s/^/\/\/ /g'

Patch forthcoming.
Comment on attachment 436247 [details] [diff] [review]
Patch

Nevermind...this patch fails a couple of tests...

Time to tweak
Attachment #436247 - Flags: review?(hskupin) → review-
Please also keep in mind that we have multiple lines in some tests.
Created attachment 436255 [details] [diff] [review]
Patch (1.9.1)
Attachment #436247 - Attachment is obsolete: true
Attachment #436255 - Flags: review?(hskupin)
Created attachment 436259 [details] [diff] [review]
Patch (default)
Attachment #436256 - Attachment is obsolete: true
Attachment #436259 - Flags: review?(hskupin)
Created attachment 436261 [details] [diff] [review]
Patch (default)
Attachment #436259 - Attachment is obsolete: true
Attachment #436261 - Flags: review?(hskupin)
Attachment #436259 - Flags: review?(hskupin)
Created attachment 436268 [details] [diff] [review]
Patch (1.9.1)
Attachment #436255 - Attachment is obsolete: true
Attachment #436268 - Flags: review?(hskupin)
Attachment #436255 - Flags: review?(hskupin)
We should target that patch for beginning next week. I would propose Monday. Anthony, if you could update both patches by Monday it would be perfect. Thanks.
Status: NEW → ASSIGNED
Reassigning to Henrik for follow-up work.  I have fever and will not be able to finish this by tomorrow.
Assignee: anthony.s.hughes → hskupin
Attachment #436261 - Attachment is obsolete: true
Attachment #436261 - Flags: review?(hskupin)
Attachment #436268 - Attachment is obsolete: true
Attachment #436268 - Flags: review?(hskupin)
Created attachment 441589 [details] [diff] [review]
Patch v1.1 (default)

This patch depends on the work for the Addons API. So please apply on top of it for testing purposes.
Attachment #441589 - Flags: review?(anthony.s.hughes)
Created attachment 441591 [details] [diff] [review]
Patch v1.1 (mozilla1.9.1)
Attachment #441591 - Flags: review?(anthony.s.hughes)
Attachment #441589 - Flags: review?(anthony.s.hughes) → review+
Attachment #441591 - Flags: review?(anthony.s.hughes) → review+
Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/9fe002fe2778
http://hg.mozilla.org/qa/mozmill-tests/rev/711fe8fa2363
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.