555585 - [test] Remove Litmus meta data from Mozmill tests

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We put the Litmus meta data into all of our tests because we wanted to sync the results from Brasstacks with Litmus. Seeing the reality we will never have such a script. No-one will have time to work on it. Also when we have a green test-run we could simply use a bookmarklet on Litmus to automatically mark all the tests as passed. That should be a trivial task.

The work which is required from us to keep track of the Litmus id in our tests doesn't correlate to it's usefulness. That's why we wanna remove those lines from all tests in the default and mozilla1.9.1 branch. 

Is anyone familiar with sed and can create a helpful regex to remove those lines automatically? 

This is an example:

> /**
>  * Map test functions to litmus tests
>  */
> testPermissionsDisabled.meta = {litmusids : [7397]};

Comment 1

[u279076]

Assigning to myself.  I spoke with Matt about this and he actually just wants the lines commented out.  This will be a lot easier than removing the 4 lines. :)

Comment 2

[u279076]

After some research, I've come up with the following command:
grep -B 1 -A 2 -lr -e 'litmusids : ' ./firefox | xargs sed -i '$s/^/\/\/ /g'

Patch forthcoming.

Comment 3

[u279076]

Attachment: Patch

Comment 4

[u279076]

Comment on attachment 436247 [details] [diff] [review]
Patch

Nevermind...this patch fails a couple of tests...

Time to tweak

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Please also keep in mind that we have multiple lines in some tests.

Comment 6

[u279076]

Attachment: Patch (1.9.1)

Comment 7

[u279076]

Attachment: Patch

Comment 8

[u279076]

Attachment: Patch (default)

Comment 9

[u279076]

Attachment: Patch (default)

Comment 10

[u279076]

Attachment: Patch (1.9.1)

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We should target that patch for beginning next week. I would propose Monday. Anthony, if you could update both patches by Monday it would be perfect. Thanks.

Comment 12

[u279076]

Reassigning to Henrik for follow-up work.  I have fever and will not be able to finish this by tomorrow.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1.1 (default)

This patch depends on the work for the Addons API. So please apply on top of it for testing purposes.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1.1 (mozilla1.9.1)

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/9fe002fe2778
http://hg.mozilla.org/qa/mozmill-tests/rev/711fe8fa2363