555621 - "Find in This Page" (and "Find Again" and "Find Previous") loops back to the start (or end!) of a page.

Status: RESOLVED WORKSFORME

(SeaMonkey :: Find In Page, defect)

Description

[Dave Young]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.1.9) Gecko/20100317 NOT Firefox/3.5 SeaMonkey/2.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.1.9) Gecko/20100317 SeaMonkey/2.0.4

In SeaMonkey 2.x, when using "Find in This Page", "Find Again" or "Find Previous" the search loops back to the start (or end!) of the page instead of stopping and displaying the message "The text you entered was not found", as happens in SeaMonkey 1.1.18.

Reproducible: Always

Steps to Reproduce:
1. Open any web page.
2. Select "Find in This Page"
3. Enter a search term (one that is present in the page).
4. Repeatedly click on "Find".
Actual Results:  
The search repeatedly loops back to the start (or end, if using "Find Previous") of the page when it reaches the end (or start, if using "Find Previous") of the page. This also applies to "Find Again".

Expected Results:  
The search should stop at the end of the page (or beginning, if using "Find Previous") and display the message "The text you entered was not found".

Comment 1

[Robert Kaiser]

IIRC, this works if you uncheck the "Wrap" option in the "Find in Page" dialog.

Comment 2

[Dave Young]

(In reply to comment #1)
> IIRC, this works if you uncheck the "Wrap" option in the "Find in Page" dialog.

Yes, Robert, you are quite correct! However, if I understand the "Wrap" option correctly, isn't it for finding sentences that are split over more than one line of text? In which case, I would still expect the search to stop, once the complete page had been searched.

Regards,

Dave.

Comment 3

[Robert Kaiser]

Dave, no, you misunderstood what "Wrap" means there - it just means that searching "wrapped" in a way that it continues at the start when it runs off the end. Lines are just visual, but nothing the code really cares about.

As this bug is a pure misunderstanding, I'll close this as "work for me".

We're working on a solution for 2.1 that doesn't require a popup dialog anyhow - and we can't change the strings for 2.0, so all we can do here is explain what the word means. :)

Comment 4

[Dave Young]

(In reply to comment #3)
> Dave, no, you misunderstood what "Wrap" means there - it just means that
> searching "wrapped" in a way that it continues at the start when it runs off
> the end. Lines are just visual, but nothing the code really cares about.

Robert, thanks for your explanation of the meaning of "Wrap" in this context! Sorry for my misunderstanding. ;)

> As this bug is a pure misunderstanding, I'll close this as "work for me".

Fair enough, I'll consider it closed, then.

Regards,

Dave.

Comment 5

[Tom Schneider]

> The search should stop at the end of the page (or beginning, if using "Find
> Previous") and display the message "The text you entered was not found".

I disagree very strongly.  Having it stop slows one down.  A flag can be displayed, but a user should never have to click boxes 'ok'.  This wastes
a lot of time!