555632 - SM 1.x to 2.x profile migration: some (user defined !?) preferences are not migrated

Status: RESOLVED WONTFIX

(SeaMonkey :: Startup & Profiles, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.3a4pre) Gecko/20100328
SeaMonkey/2.1a1pre] (comm-central-trunk-win32-debug/1269807367)

Preferences like
user_pref("browser.dom.window.dump.enabled", true);
are not migrated,
though they are still valid in SM 2.x.

I guess they should be added in either
{
269 static
270 nsSeamonkeyProfileMigrator::PrefTransform gTransforms[] = {
271   MAKESAMETYPEPREFTRANSFORM("addressbook.throbber.url",                String),
...
}
or
{
604   static const char* branchNames[] =
605   {
606     // Keep the three below first, or change the indexes below
607     "mail.identity.",
...
}

NB: I'll check the other prefs once I get an answer about how to handle this issue.

Comment 1

[[e-mail]]

The idea is to migrate the profile, not duplicate it.

Comment 2

[Robert Kaiser]

Right, as Neil says. Of course, migrating more prefs where we know they still exist unchanged in 2.x is OK, but but we should not add paths that might/will migrate obsolete prefs.
So, anything we add there needs to be carefully double-checked in at least 1.9.1 code.

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)
> NB: I'll check the other prefs once I get an answer about how to handle this
> issue.

I think I've figured it out (at least for this pref): I'm checking the other ones.

(In reply to comment #1)
> The idea is to migrate the profile, not duplicate it.

Sure, but SeaMonkey even has a UI for this very pref:
http://mxr.mozilla.org/comm-central/search?string=browser.dom.window.dump&case=1&find=%2Fpref-debug%5C.xul%24
/suite/debugQA/content/pref-debug.xul

(In reply to comment #2)

Obviously.

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Migrate all prefs which have a UI in debugQA, Port bug 414843, Rewrite MAKESAMETYPEPREFTRANSFORM()

Based on mxr searches, to c-c, from mozilla(1.7).

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 436083 [details] [diff] [review]
(Av1) Migrate all prefs which have a UI in debugQA, Port bug 414843, Rewrite MAKESAMETYPEPREFTRANSFORM()


"approval-seamonkey2.0.5=?":
I'll let the dtd as is if removals are not allowed on branch. Are they?

Comment 6

[[e-mail]]

Comment on attachment 436083 [details] [diff] [review]
(Av1) Migrate all prefs which have a UI in debugQA, Port bug 414843, Rewrite MAKESAMETYPEPREFTRANSFORM()

>+  MAKESAMETYPEPREFTRANSFORM("extensions.dss.enabled",                  Bool),
1.x didn't have this, and Thunderbird had no UI for it or any of these prefs?

>+  MAKESAMETYPEPREFTRANSFORM("layout.reflow.dumpframebyframecounts",    Bool),
>+  MAKESAMETYPEPREFTRANSFORM("layout.reflow.dumpframecounts",           Bool),
>+  MAKESAMETYPEPREFTRANSFORM("layout.reflow.showframecounts",           Bool),
Not sure it's worth migrating these. Or the nglayout prefs. Or xul.debug.box?

Comment 7

[Serge Gautherie (:sgautherie)]

Attachment: (Av1a) Migrate all prefs which have a UI in debugQA, Port bug 414843, Rewrite MAKESAMETYPEPREFTRANSFORM()

Av1, with comment 6 suggestion(s),
plus TB update for past and present: same prefs after all.

(In reply to comment #6)

> 1.x didn't have this, and Thunderbird had no UI for it or any of these prefs?

http://mxr.mozilla.org/mozilla1.7/search?string=extensions.dss.enabled&case=on
Right! 'mozilla' is 1.9.0 not 1.7 :-< This pref was added in 'mozilla1.8.0'.

> Not sure it's worth migrating these. Or the nglayout prefs. Or xul.debug.box?

I assume they are "all" seldom used, but what's wrong with migrating them (when they are)?

Comment 8

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> Thunderbird had no UI for it or any of these prefs?

Don't know, don't care: the (gecko) prefs can be defined "manually".

Comment 9

[Robert Kaiser]

Comment on attachment 436229 [details] [diff] [review]
(Av1a) Migrate all prefs which have a UI in debugQA, Port bug 414843, Rewrite MAKESAMETYPEPREFTRANSFORM()

I'm not qualified for such a review, did you see me being a peer for migration code now?

Also, please only ask for approval once a patch has been reviewed.

Comment 10

[Serge Gautherie (:sgautherie)]

(In reply to comment #9)
> did you see me being a peer for migration code now?

(Hard to tell ... See bug 448687.)

Comment 11

[Serge Gautherie (:sgautherie)]

Attachment: (Av1b) Migrate all prefs which have a UI in debugQA, Port bug 414843, Rewrite MAKESAMETYPEPREFTRANSFORM()

Av1a, with a missing comma in nsThunderbirdProfileMigrator.cpp.

I built and tried this locally: it migrated the additinal prefs :-)

Comment 12

[Serge Gautherie (:sgautherie)]

Attachment: (Av1c) Migrate all prefs which have a UI in debugQA, Port bug 414843, Rewrite MAKESAMETYPEPREFTRANSFORM()

Av1b, with "extensions.dss.enabled" re-added.

(In reply to comment #7)
> Right! 'mozilla' is 1.9.0 not 1.7 :-< This pref was added in 'mozilla1.8.0'.

You confused me: (MAS 1.7 did not but) SM 1.x did support this pref. (Same for TB.)

Comment 13

[[e-mail]]

(In reply to comment #12)
> You confused me: (MAS 1.7 did not but) SM 1.x did support this pref.
It was briefly supported in SeaMonkey 1.5a before it became suiterunner.

> (Same for TB.)
But it had no UI for it?

Comment 14

[[e-mail]]

Or indeed TB had no UI for any of these prefs?

Actually I'm going to be generous here and allow references such as mozillazine to count as pref UI, so migrating e.g. the dump pref would seem reasonable.

Comment 15

[Philip Chee]

Serge, are you still working on this bug?

Comment 16

[Philip Chee]

libreg is dead. And migration code from 1.x profiles has been removed. WONTFIX.