Created attachment 435556 [details] [diff] [review] The fix The find service and the charset-menu (intl) both currently exist in xpfe/components. As we're tidying up xpfe/ we should move them to more appropraite locations. Find service is used within toolkit and others: http://mxr.mozilla.org/comm-central/search?string=nsIFindService The charset-menu also seems to be best moved to toolkit: http://mxr.mozilla.org/comm-central/search?string=charset-menu The attached patch does the required moves. I've also integrated the component registration code into the toolkit comps module as that would seem to reduce the number of modules being built and initialised.
Attachment #435556 - Flags: review?(dtownsend)
Ping for review...
Attachment #435556 - Flags: review?(dtownsend) → review+
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
Note: It's been suggested (by Ted Mielczarek) the following build-time nastygram on mozilla-central may be fallout from this fix: make: Entering directory `/home/martinpacker/mozilla-central/toolkit/components/build' make: *** No rule to make target `../find/src/libmozfind_s.a', needed by `libtoolkitcomps.a'. Stop. Could someone take a look and see. (And apologies if this isn't the right way to flag this
You need to log in before you can comment on or make changes to this bug.