555658 - Move Find Service and intl charset-menu code to toolkit

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

The find service and the charset-menu (intl) both currently exist in xpfe/components. As we're tidying up xpfe/ we should move them to more appropraite locations.

Find service is used within toolkit and others:

http://mxr.mozilla.org/comm-central/search?string=nsIFindService

The charset-menu also seems to be best moved to toolkit:

http://mxr.mozilla.org/comm-central/search?string=charset-menu

The attached patch does the required moves. I've also integrated the component registration code into the toolkit comps module as that would seem to reduce the number of modules being built and initialised.

Comment 1

[Mark Banner (:standard8)]

Ping for review...

Comment 2

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/mozilla-central/rev/416b9b6ffc77

Comment 3

[Martin Packer]

Note: It's been suggested (by Ted Mielczarek) the following build-time nastygram on mozilla-central may be fallout from this fix:

make[6]: Entering directory `/home/martinpacker/mozilla-central/toolkit/components/build'
make[6]: *** No rule to make target `../find/src/libmozfind_s.a', needed by `libtoolkitcomps.a'. Stop.

Could someone take a look and see. (And apologies if this isn't the right way to flag this