Move Find Service and intl charset-menu code to toolkit

RESOLVED FIXED in mozilla1.9.3a5

Status

()

Toolkit
Build Config
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
mozilla1.9.3a5
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 435556 [details] [diff] [review]
The fix

The find service and the charset-menu (intl) both currently exist in xpfe/components. As we're tidying up xpfe/ we should move them to more appropraite locations.

Find service is used within toolkit and others:

http://mxr.mozilla.org/comm-central/search?string=nsIFindService

The charset-menu also seems to be best moved to toolkit:

http://mxr.mozilla.org/comm-central/search?string=charset-menu

The attached patch does the required moves. I've also integrated the component registration code into the toolkit comps module as that would seem to reduce the number of modules being built and initialised.
Attachment #435556 - Flags: review?(dtownsend)
(Assignee)

Updated

8 years ago
Attachment #435556 - Attachment is patch: true
Attachment #435556 - Attachment mime type: application/octet-stream → text/plain
(Assignee)

Comment 1

8 years ago
Ping for review...
Attachment #435556 - Flags: review?(dtownsend) → review+
(Assignee)

Comment 2

8 years ago
Checked in: http://hg.mozilla.org/mozilla-central/rev/416b9b6ffc77
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5

Comment 3

8 years ago
Note: It's been suggested (by Ted Mielczarek) the following build-time nastygram on mozilla-central may be fallout from this fix:

make[6]: Entering directory `/home/martinpacker/mozilla-central/toolkit/components/build'
make[6]: *** No rule to make target `../find/src/libmozfind_s.a', needed by `libtoolkitcomps.a'. Stop.

Could someone take a look and see. (And apologies if this isn't the right way to flag this
Blocks: 564606
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.