55569 - accel+I should bring up Page Info

Status: VERIFIED FIXED

(SeaMonkey :: Page Info, defect, P3)

Description

[sairuh (rarely reading bugmail)]

suzanne/lake, not sure which engr should fix this...but at least on the
commercial side, Ctrl/Command+I brings up NIM, rather than bringing up Page Info
(as it has in 4.x).

Comment 1

[sairuh (rarely reading bugmail)]

what does accel+I bring up on mozilla? does it bring up page info? if so, then
this is commercial only and should be moved to bugscape (tho' i don't have
access for that).

Comment 2

[scalkins]

This is in Bugscape as bug http://Bugscape.netscape.com/show_bug.cgi?id=2263
It was  set to post seamonkey 6.0 by PDT 

Comment 3

[sairuh (rarely reading bugmail)]

yep, this needs to fixed on the mozilla side o'things, too. accel+I isn't even
listed in the View menu (or, context menus, but that's bug 41443).

Comment 4

[don]

German, you wanna make the call on this one?

Comment 5

[sairuh (rarely reading bugmail)]

methinks jglick would make the call on this one, since she wrote up
http://mozilla.org/projects/ui/netscape/accel_keys/index.html...

however, i noticed that Ctrl+I is in red there, which might be a label for
"ambiguous" (is that the case?). if so, i'd much prefer that accel+I be used for
page info, since it's consistent with 4.x and makes sense across both netscape6
and mozilla. imho. :)

Comment 6

[Blake Ross]

Just a note: most AOL users might expect Ctrl+I to bring up the IM form, since 
that's what it does in the AOL software (and, since instant messenging is a 
huge part of the AOL software, that accelerator is probably extremely 
wellknown).  Still, I would tend to agree that backwards compatibility with 
your own software should prevail over compatibility with the software of your 
parent company...(meaning Page Info should be Ctrl+I)

There should, however, be *some* easily accessible, somewhat intuitive 
accelerator for instant messenging, considering the feature will probably be 
used often.

Comment 7

[Matthew T (active 1999-2002)]

See also bug 55170. Cmd+I has meant Info/Properties on the Mac since the 
beginning of time, and it's Really Not a Good Idea to change it.

Far be it from me to help out Netscape with their proprietary UI problems,
but ... Ctrl+Shift+M for a new instant message would go nicely with the current 
Ctrl+N, Ctrl+Shift+N, and Ctrl+M shortcuts for various `New xyz' commands.

Comment 8

[jglick]

Ctrl+I is in the accelerator spec in red because Mail Compose and Editor are 
using it for "Italics" and other apps are using it for "New Instant Message". 
This is a very bad conflict in my opinion because you shouldn't use the same 
accelerator to launch a new instance of an app AND have the accelerator 
be for some other function in other situations.  Accelerators that launch a new 
instance of an app should Always be unique. This is what the Bugscape bug 
referenced above (by  scalkins) is about.  Worse, in IM Compose, "Ctrl+I" should 
be italics (like Mail Compose and Composer) but instead brings up a new IM 
window.  AIM needs to pick something different.  Thats another bug.  Side track.

As for <accelerator key>+I, I believe it should be used for "Italics" in 
composing situations, such as Mail Compose, Composer and IM Compose.  But in non 
composing windows, should be used for "Info" (Page Info in Browser, AB info in 
Address Book, etc.).  (Note: Ctrl+B works similar, "Bold" in composing 
situations and "Bookmarks" in others.) Accelerator spec has been updated to 
reflect this. (need help getting this updated on Mozilla).

Back to Don to be assigned to an Engineer.

Comment 9

[Peter "jag" Annema]

gramps, feel free to give this to me, it's an easy fix.

Comment 10

[sairuh (rarely reading bugmail)]

jag, i'll give it you (unless don protests ;).

jglick, feel free to either attach your updated spec here, or email it to me and
i'll check it in to the doc tree.

Comment 11

[jglick]

Attachment: Updated Accelerator spec

Comment 12

[jglick]

Attachment: Updated Accelerator spec. Really.

Comment 13

[jglick]

Please use the most recently posted spec update.  Thanks for the help.

Comment 14

[sairuh (rarely reading bugmail)]

checked it in... (might take anywhere from 15min - several hours before you see
the change on the website, tho'.)

Comment 15

[Peter "jag" Annema]

Attachment: [patch] make accel i show up in navigator menu

Comment 16

[Peter "jag" Annema]

There currently isn't a View Info in mail/news, adding that is quite a bit more
work. Therefore this fix which fixes navigator so that's done and over with.

Comment 17

[sairuh (rarely reading bugmail)]

hmmm, jag has proffered a patch... if this gets reviewed (and okay'd), could we
check this into the branch as well? (thus nominating for rtm.)

Comment 18

[jglick]

If this makes it into the branch, we will have a conflict with "Ctrl+I" for rtm 
(netscape build). In navigator, it would be both Page Info and New IM.

If we can get the IM team to fix bugscape 2263, this could go in for rtm. If 
not, it should probably be just in the trunk and we would need to be sure 2263 
gets fixed in the truck as well.

Comment 19

[Ben Goodger (use ben at mozilla dot org for email)]

r=[e-mail].

Thanks!

Comment 20

[don]

Too bad jag can't attach a fix for the AIM bug in bugscape too.  Ben, can you
whip one real quick?

Comment 21

[selmer (gone)]

rtm-, this isn't happening for this release, but you can work it into the trunk.

Comment 22

[Brendan Eich [:brendan]]

a=[e-mail].

/be

Comment 23

[Peter "jag" Annema]

Checked in, marking fixed.

Comment 24

[sairuh (rarely reading bugmail)]

vrfy fixed using trunk bits [commercial]: 2000.11.21.08 [linux rh 6.2, winnt]
and 2000.11.21.13 [mac os 9.0].