Closed Bug 555785 Opened 11 years ago Closed 10 years ago

Port Bug 553073 (and bug 554997) CFBundleIdentifier in Info.plist.in is hardcoded as "org.mozilla.thunderbird"

Categories

(Thunderbird :: OS Integration, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.3a1

People

(Reporter: standard8, Assigned: Nomis101)

References

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #553073 +++

The CFBundleIdentifier in /mail/app/macbuild/Contents/Info.plist.in is hardcoded as "org.mozilla.thunderbird", which causes default mail issues when running shredder and thunderbird on the same machine.

See bug 553073 for the rest of the info. I'd also like a solution to bug 554997 before porting this, hence the dependencies.
Note to self: do after 3.1b2, then if bug 554997 hasn't been fixed, we're not affecting users who are upgrading from 3.1b1 (Lanikai branding) to 3.1b2 (Thunderbird branding), we just need to make sure that bug is fixed by the next time we do such a switch.
Whiteboard: [do after 3.1beta2]
Attached patch patch (C&P from 553073) (obsolete) — Splinter Review
I have a patch for this (simple copy&paste from bug 553073). I've tested this with official and unofficial branding. With official branding CFBundleIdentifier is set to org.mozilla.thunderbird and with unofficial branding it is org.mozilla.shredder (only tested with 3.2, but I assume it will work the same for 3.1).
Depends on: 314794
No longer depends on: 554997
Depends on: 554997
Comment on attachment 439656 [details] [diff] [review]
patch (C&P from 553073)

>-	sed -e "s/%APP_VERSION%/$(MOZ_APP_VERSION)/" -e "s/%APP_NAME%/$(APP_NAME)/" $(srcdir)/macbuild/Contents/Info.plist.in > $(DIST)/$(APP_NAME).app/Contents/Info.plist
...
>+	sed -e "s/%APP_VERSION%/$(APP_VERSION)/" -e "s/%APP_NAME%/$(APP_NAME)/" -e "s/%LOWER_APP_NAME%/$(LOWER_APP_NAME)/" $(srcdir)/macbuild/Contents/Info.plist.in > $(DIST)/$(APP_NAME).app/Contents/Info.plist

Our makefile doesn't have APP_VERSION, so that bit should remain as MOZ_APP_VERSION.

Nomis101, want to update now that the dependent bugs seem fixed?
Assignee: bugzilla → Nomis101
Attached patch patch v2Splinter Review
OK, fixed the overlooked thing.
Attachment #439656 - Attachment is obsolete: true
Attachment #480517 - Flags: review?(bugzilla)
Comment on attachment 480517 [details] [diff] [review]
patch v2

Thanks for the update
Attachment #480517 - Flags: review?(bugzilla) → review+
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/3df8b762deca
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [do after 3.1beta2]
Target Milestone: --- → Thunderbird 3.3a1
You need to log in before you can comment on or make changes to this bug.