555785 - Port Bug 553073 (and bug 554997) CFBundleIdentifier in Info.plist.in is hardcoded as "org.mozilla.thunderbird"

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, defect)

Description

[Mark Banner (:standard8)]

+++ This bug was initially created as a clone of Bug #553073 +++

The CFBundleIdentifier in /mail/app/macbuild/Contents/Info.plist.in is hardcoded as "org.mozilla.thunderbird", which causes default mail issues when running shredder and thunderbird on the same machine.

See bug 553073 for the rest of the info. I'd also like a solution to bug 554997 before porting this, hence the dependencies.

Comment 1

[Mark Banner (:standard8)]

Note to self: do after 3.1b2, then if bug 554997 hasn't been fixed, we're not affecting users who are upgrading from 3.1b1 (Lanikai branding) to 3.1b2 (Thunderbird branding), we just need to make sure that bug is fixed by the next time we do such a switch.

Comment 2

[Nomis101]

Attachment: patch (C&P from 553073)

I have a patch for this (simple copy&paste from bug 553073). I've tested this with official and unofficial branding. With official branding CFBundleIdentifier is set to org.mozilla.thunderbird and with unofficial branding it is org.mozilla.shredder (only tested with 3.2, but I assume it will work the same for 3.1).

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 439656 [details] [diff] [review]
patch (C&P from 553073)

>-	sed -e "s/%APP_VERSION%/$(MOZ_APP_VERSION)/" -e "s/%APP_NAME%/$(APP_NAME)/" $(srcdir)/macbuild/Contents/Info.plist.in > $(DIST)/$(APP_NAME).app/Contents/Info.plist
...
>+	sed -e "s/%APP_VERSION%/$(APP_VERSION)/" -e "s/%APP_NAME%/$(APP_NAME)/" -e "s/%LOWER_APP_NAME%/$(LOWER_APP_NAME)/" $(srcdir)/macbuild/Contents/Info.plist.in > $(DIST)/$(APP_NAME).app/Contents/Info.plist

Our makefile doesn't have APP_VERSION, so that bit should remain as MOZ_APP_VERSION.

Nomis101, want to update now that the dependent bugs seem fixed?

Comment 4

[Nomis101]

Attachment: patch v2

OK, fixed the overlooked thing.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 480517 [details] [diff] [review]
patch v2

Thanks for the update

Comment 6

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/3df8b762deca