555800 - Support links from Lorentz (version 3.6.3plugin1) should redirect correctly

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[Benjamin Smedberg]

Lorentz is a branch of 1.9.2 where out of process plugins is being backported for future inclusion in Firefox 3.6.*. We're preparing a beta now, and discovered that in-product SUMO links show a 404 error instead of redirecting correctly:

e.g.
http://support.mozilla.com/1/firefox/3.6.3plugin1/WINNT/en-US/firefox-help
http://support.mozilla.com/1/firefox/3.6.3plugin1/WINNT/en-US/plugin-crashed

The plugin-crashed link is especially important because it is new UI which users will be testing very actively. Can we quickly set up the proper redirects so that these links work by the end of the week?

Note that we're planning possible weekly betas, so 3.6.3plugin2 and 3 should work also.

Comment 1

[James Socol [:jsocol, :james]]

Is "#.#.#plugin#" a new style of version number we can expect to see more often?

And how soon do you expect the beta to go out?

Comment 2

[Benjamin Smedberg]

It is a numbering specific to the Lorentz branch. We're hoping to have the beta go out later this week, sometime before Friday.

Comment 3

[James Socol [:jsocol, :james]]

QA is OK with adding this to 1.5.3 which goes out tomorrow (/me knocks on wood).

I'm going to make versions much more liberal in what they match, probably just

    \d\.\d[^/]*

That should handle pretty much anything.

Comment 4

[James Socol [:jsocol, :james]]

Attachment: makes version numbers in the Rewrites much more liberal

This patch essentially replaces the old version number regex with a more liberal one.

Old & busted: [\.0-9ab]+(?:pre)?

New hotness: [0-9]+\.[0-9]+[^/]*

This should match anything that starts with two numbers separated by a period and anything trailing after it up until the next /.

Comment 5

[James Socol [:jsocol, :james]]

r64965.

QA: All previous rewrites should still work and destinations are unchanged.

Comment 6

[Vishal Kamdar [:vish_moz]]

Verified, FIXED.

Updated and ran automation script at http://viewvc.svn.mozilla.org/vc/projects/sumo/tests/frontend/php_tests/

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

No need for a manual testcase since this is automated.