Closed
Bug 555810
Opened 16 years ago
Closed 3 years ago
Cleanup maemo defines
Categories
(Firefox Build System :: General, defect)
Tracking
(status1.9.2 .4-fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | .4-fixed |
People
(Reporter: mfinkle, Unassigned)
Details
Attachments
(1 file)
|
1.33 KB,
patch
|
dougt
:
review+
pavlov
:
approval1.9.2.4+
|
Details | Diff | Splinter Review |
We still have a few old MOZ_PLATFORM_HILDON in m-192, so this patch fixes that.
See bug 543976
Attachment #435699 -
Flags: review?(dougt)
|
||
Updated•16 years ago
|
Attachment #435699 -
Flags: review?(dougt) → review+
|
|
||
Comment 1•16 years ago
|
||
Comment on attachment 435699 [details] [diff] [review]
patch
>-#ifdef MOZ_PLATFORM_HILDON
>+#if (MOZ_PLATFORM_MAEMO == 5) && defined (MOZ_ENABLE_GNOMEVFS)
> if(NS_SUCCEEDED(LaunchDefaultWithDBus(PromiseFlatCString(nativePath).get())))
> return NS_OK;
> #endif
#ifdef MOZ_PLATFORM_MAEMO
|
Reporter | |
Comment 2•16 years ago
|
||
on IRC Doug suggested not changing to:
#ifdef MOZ_PLATFORM_MAEMO
and just leaving the patch as is
Assignee: nobody → mark.finkle
|
|
Reporter | |
Updated•16 years ago
|
Attachment #435699 -
Flags: approval1.9.2.3?
|
||
Updated•16 years ago
|
Attachment #435699 -
Flags: approval1.9.2.3? → approval1.9.2.3+
|
|
Reporter | |
Comment 3•16 years ago
|
||
status1.9.2:
--- → .4-fixed
|
|
Reporter | |
Updated•9 years ago
|
Assignee: mark.finkle → nobody
|
||
Updated•8 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•3 years ago
|
Severity: normal → S3
|
||
Updated•3 years ago
|
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•