555835 - Optimize Core Graphics drawing model for OOPP

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Benoit Girard (:BenWa)]

Currently the whole plug-in area is refreshed (and ignored by the parent clip). We need to support refreshing only the target area for efficiency.

Comment 1

[Benoit Girard (:BenWa)]

I'm also working on a patch that optimizes the shared image allocation to SetWindow (to manage resizing) instead of doing it per frame.

I'm also investigating the best way to resolve the color matching slowdown.

Comment 2

[Benoit Girard (:BenWa)]

Attachment: CG OOP Color Optimization

This patch changes the color space of the OOP CGContext to use the system' color profile. This prevent needless generic->system color matching. It also changes CGColorSpaceRef/CGContextRef allocation so that they are made only once instead of per frame.

These changes lead to a significant speed improvement.

Comment 3

[Benoit Girard (:BenWa)]

Attachment: CG OOP Color Optimization

Made an addition to handle resizing the plug-in window correctly.

Comment 4

[Benoit Girard (:BenWa)]

Attachment: CG OOP Color Optimization

Fixed bitrot.

Comment 5

[Benoit Girard (:BenWa)]

Comment on attachment 436477 [details] [diff] [review]
CG OOP Color Optimization

bsmedberg, josh wanted me to ask you for superreview. In particular we need to include code from layout/generic/nsPluginUtilsOSX.h so we wanted to check this change with you. Currently we not using much code from it yet but with the upcoming out of process Core Animation patch we will be using a significant amount of code from it.

--- a/dom/plugins/Makefile.in
+++ b/dom/plugins/Makefile.in
@@ -117,6 +117,7 @@
 LOCAL_INCLUDES = \
   -I$(topsrcdir)/modules/plugin/base/public/ \
   -I$(topsrcdir)/modules/plugin/base/src/ \
+  -I$(topsrcdir)/layout/generic/ \
   $(NULL)
 
 include $(topsrcdir)/config/config.mk

Comment 6

[Benjamin Smedberg]

Would it make more sense to export that header, rather than spread LOCAL_INCLUDES around?

Comment 7

[Benoit Girard (:BenWa)]

Sure. I was under the impression that it would be less desirable to do that since it would be exporting that header to the whole project.

Comment 8

[Benoit Girard (:BenWa)]

Attachment: CG OOP Color Optimization

Comment 9

[Benoit Girard (:BenWa)]

Attachment: CG OOP Color Optimization

Fixed spaces to tabs in layout/generic/Makefile.in

Comment 10

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/114b74248238

Comment 11

[Benoit Girard (:BenWa)]

I still need to honor NPCocoaEventDraw rect to get good performance.

Comment 13

[Benoit Girard (:BenWa)]

I tried drawing only the subrect but I did not see any performance improvements.