[HTML5] Split HILO_ACCEL into a separate class

RESOLVED FIXED

Status

()

Core
HTML: Parser
P4
trivial
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: hsivonen, Assigned: hsivonen)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

8 years ago
nsHtml5NamedCharacters has a member called HILO_ACCEL. This poses two problems:
 1) It's ugly in C++.
 2) Having HILO_ACCEL and the named character tables in the same class makes the Java source fail to compile with java.

Therefore, HILO_ACCEL should be split into a separate class.
(Assignee)

Comment 1

8 years ago
Created attachment 453353 [details] [diff] [review]
Generator patch
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Attachment #453353 - Flags: review?(jonas)
(Assignee)

Comment 2

8 years ago
Created attachment 453354 [details] [diff] [review]
Output patch
Attachment #453354 - Flags: review?(jonas)
Comment on attachment 453353 [details] [diff] [review]
Generator patch

rs=me
Attachment #453353 - Flags: review?(jonas) → review+
Attachment #453354 - Flags: review?(jonas) → review+
(Assignee)

Comment 4

8 years ago
Comment on attachment 453354 [details] [diff] [review]
Output patch

Requesting approval. This patch is low-risk, since it merely moves code around. It is desirable, because currently the Gecko copy and the upstream of the HTML5 parser are out of sync and this patch puts them in sync making other fixes simpler.
Attachment #453354 - Flags: approval2.0?
(Assignee)

Comment 5

8 years ago
See also the #whatwg IRC log from 
http://krijnhoetmer.nl/irc-logs/whatwg/20100720#l-624
to about the end of that day's log.
(Assignee)

Comment 6

8 years ago
(In reply to comment #5)
> See also the #whatwg IRC log from 
> http://krijnhoetmer.nl/irc-logs/whatwg/20100720#l-624
> to about the end of that day's log.

Sorry. That comment was supposed to go into another bug.

Updated

8 years ago
Attachment #453354 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 7

8 years ago
http://hg.mozilla.org/mozilla-central/rev/dfaba4e449bd
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.