555941 - [HTML5] Split HILO_ACCEL into a separate class

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect, P4)

Description

[Henri Sivonen (:hsivonen)]

nsHtml5NamedCharacters has a member called HILO_ACCEL. This poses two problems:
 1) It's ugly in C++.
 2) Having HILO_ACCEL and the named character tables in the same class makes the Java source fail to compile with java.

Therefore, HILO_ACCEL should be split into a separate class.

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Generator patch

Comment 2

[Henri Sivonen (:hsivonen)]

Attachment: Output patch

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 453353 [details] [diff] [review]
Generator patch

rs=me

Comment 4

[Henri Sivonen (:hsivonen)]

Comment on attachment 453354 [details] [diff] [review]
Output patch

Requesting approval. This patch is low-risk, since it merely moves code around. It is desirable, because currently the Gecko copy and the upstream of the HTML5 parser are out of sync and this patch puts them in sync making other fixes simpler.

Comment 5

[Henri Sivonen (:hsivonen)]

See also the #whatwg IRC log from 
http://krijnhoetmer.nl/irc-logs/whatwg/20100720#l-624
to about the end of that day's log.

Comment 6

[Henri Sivonen (:hsivonen)]

(In reply to comment #5)
> See also the #whatwg IRC log from 
> http://krijnhoetmer.nl/irc-logs/whatwg/20100720#l-624
> to about the end of that day's log.

Sorry. That comment was supposed to go into another bug.

Comment 7

[Henri Sivonen (:hsivonen)]

http://hg.mozilla.org/mozilla-central/rev/dfaba4e449bd