[HTML5] Split HILO_ACCEL into a separate class

RESOLVED FIXED

Status

()

defect
P4
trivial
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: hsivonen, Assigned: hsivonen)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

nsHtml5NamedCharacters has a member called HILO_ACCEL. This poses two problems:
 1) It's ugly in C++.
 2) Having HILO_ACCEL and the named character tables in the same class makes the Java source fail to compile with java.

Therefore, HILO_ACCEL should be split into a separate class.
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Attachment #453353 - Flags: review?(jonas)
Posted patch Output patchSplinter Review
Attachment #453354 - Flags: review?(jonas)
Comment on attachment 453353 [details] [diff] [review]
Generator patch

rs=me
Attachment #453353 - Flags: review?(jonas) → review+
Comment on attachment 453354 [details] [diff] [review]
Output patch

Requesting approval. This patch is low-risk, since it merely moves code around. It is desirable, because currently the Gecko copy and the upstream of the HTML5 parser are out of sync and this patch puts them in sync making other fixes simpler.
Attachment #453354 - Flags: approval2.0?
See also the #whatwg IRC log from 
http://krijnhoetmer.nl/irc-logs/whatwg/20100720#l-624
to about the end of that day's log.
(In reply to comment #5)
> See also the #whatwg IRC log from 
> http://krijnhoetmer.nl/irc-logs/whatwg/20100720#l-624
> to about the end of that day's log.

Sorry. That comment was supposed to go into another bug.
Attachment #453354 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/dfaba4e449bd
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.