556018 - category indication displayed incorrect in multiweek/month view and today pane

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Stefan Sitter [:ssitter]]

Attachment: screenshot of issue

Using Lightning 1.0b2pre (20100329) with Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.2pre) Gecko/20100330 Lanikai/3.1b2pre

Steps To Reproduce:
1. open Lightning preferecen dialog and assign a color to a category
2. create an event with this category
3. check display in multiweek or month view or today pane

Actual Results:
category indication is displayed incorrect with only 1 pixel height, see screenshot

Comment 1

[Stefan Sitter [:ssitter]]

Regression range: works in Lightning 1.0b2pre (20100324042445)
                  fails in Lightning 1.0b2pre (20100326042914)

Checkins during regression range: <https://hg.mozilla.org/comm-central/pushloghtml?startdate=2010-03-24+04:24:45&enddate=2010-03-26+04:29:14>

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

Attachment: Fix - v1

Comment 4

[Philipp Kewisch [:Fallen][☁️📆]]

This should take care. I'm sorry for adding another box, but I see no better way 
to align the task image in the center while keeping the category box the right
size.

Comment 5

[Martin Schröder [:mschroeder]]

Comment on attachment 440162 [details] [diff] [review]
Fix - v1

The patch works well in month and multiweek view, but a fix for the today pane is missing.

Comment 6

[Markus Adrario [:Taraman]]

Comment on attachment 440162 [details] [diff] [review]
Fix - v1

Since the Today-Pane is not fixed with this patch,
r-
for now.
If we decide to defer this to another Bug, this patch is ok.

Comment 7

[Philipp Kewisch [:Fallen][☁️📆]]

What exactly is not working for the today pane? I added an allday event and the category box is shown correctly.

Comment 8

[Philipp Kewisch [:Fallen][☁️📆]]

ping?

Comment 9

[Martin Schröder [:mschroeder]]

I messed it up with my comment#5 ... it definitely works as expected. I somehow thought we have a category indicator for non-allday events.

Comment 10

[Martin Schröder [:mschroeder]]

Comment on attachment 440162 [details] [diff] [review]
Fix - v1

r=mschroeder

Comment 11

[Philipp Kewisch [:Fallen][☁️📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/e7c67209e10b>
-> FIXED

Comment 12

[Philipp Kewisch [:Fallen][☁️📆]]

Pushed to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/563b825a1b20>
-> FIXED