[OOPP] Whitelist Flash 10.1+ and JavaPlugin2 on Mac OS X

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

Trunk
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 7 obsolete attachments)

(Assignee)

Description

9 years ago
Currently we only support Flash 10.1+ OOPP, every other plugin should not run out of process.
(Assignee)

Comment 1

9 years ago
Posted patch Flash 10.1+ whitelist (obsolete) — Splinter Review
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #436014 - Flags: review?(joshmoz)
(Assignee)

Comment 2

9 years ago
Posted patch Flash 10.1+ whitelist (obsolete) — Splinter Review
Attachment #436014 - Attachment is obsolete: true
Attachment #436014 - Flags: review?(joshmoz)
(Assignee)

Updated

9 years ago
Attachment #436034 - Flags: review?(joshmoz)
(Assignee)

Comment 3

9 years ago
Josh, we are going to have to revert to passing both the mLibrary and the aPluginTags that can be NULL since the following method on unix does not have the plugin tags:
http://mxr.mozilla.org/mozilla-central/source/modules/plugin/base/src/nsPluginsDirUnix.cpp#338
(Assignee)

Comment 4

9 years ago
Posted patch Flash 10.1+ Whitelist (obsolete) — Splinter Review
Attachment #436034 - Attachment is obsolete: true
Attachment #436034 - Flags: review?(joshmoz)
(Assignee)

Updated

9 years ago
Attachment #436185 - Flags: review?(joshmoz)
(Assignee)

Comment 5

9 years ago
Added the missing 32-bit check.
Attachment #436185 - Attachment is obsolete: true
Attachment #436185 - Flags: review?(joshmoz)
Attachment #436302 - Flags: review?(joshmoz)
(Assignee)

Comment 6

9 years ago
Here are the conditions we decided on:
- Disable on OSX 10.5 (bug 556545)
- Disable Flash 10 or lower (Carbon/Quickdraw not supported)
- Boolean pref "dom.ipc.plugins.enabled.<filename>" will be used if present.
- 32-Bit: Otherwise default to false.
- 64-Bit: Otherwise default to "dom.ipc.plugins.enabled".
Summary: Whitelist Flash 10.1+ for OOPP → [OOPP] Whitelist and Blacklist Plug-ins
(Assignee)

Updated

9 years ago
Summary: [OOPP] Whitelist and Blacklist Plug-ins → [OOPP] Whitelist and Blacklist Plug-ins on OSX
(Assignee)

Comment 7

9 years ago
Posted patch OSX OOPP Prefs (obsolete) — Splinter Review
Attachment #436302 - Attachment is obsolete: true
Attachment #436302 - Flags: review?(joshmoz)
(Assignee)

Comment 8

9 years ago
I'm not sure if this patch is exactly what we want. The current behavior is a plug-in will run out of process if it is whitelisted even if "dom.ipc.plugins.enabled" is turned off. This is how it works for other operating systems. I think we should still require "dom.ipc.plugins.enabled" to be set but I don't like having this behave differently across operation systems.

Comment 9

9 years ago
Comment on attachment 436890 [details] [diff] [review]
OSX OOPP Prefs

>+pref("dom.ipc.plugins.enabled.default.plugin", true);

Don't bother to run this out of process, it is very simple (stable) and going away soon anyway.

>+    if (aPluginTag->mVersion.EqualsASCII("10.0",4)) {

Fix this EqualsASCII usage per our IRC discussion.

>-  NPN_PLUGIN_LOG(PLUGIN_LOG_NORMAL, ("NPN_SetValue: npp=%p, var=%d\n",
>-                                     (void*)npp, (int)variable));
>+  NPN_PLUGIN_LOG(PLUGIN_LOG_NORMAL, ("NPN_SetValue: npp=%p, var=%d value=%u\n",
>+                                     (void*)npp, (int)variable, NS_PTR_TO_INT32(result)));

Get rid of this unrelated change.
Attachment #436890 - Flags: review-
(Assignee)

Comment 10

9 years ago
Posted patch Enable Flash/Java by default (obsolete) — Splinter Review
Attachment #436890 - Attachment is obsolete: true
Attachment #436973 - Flags: review?(joshmoz)
(Assignee)

Comment 11

9 years ago
Attachment #436973 - Attachment is obsolete: true
Attachment #436986 - Flags: review?(joshmoz)
Attachment #436973 - Flags: review?(joshmoz)
(Assignee)

Comment 12

9 years ago
Uploaded the wrong patch by accident.
Attachment #436986 - Attachment is obsolete: true
Attachment #436989 - Flags: review?(joshmoz)
Attachment #436986 - Flags: review?(joshmoz)

Updated

9 years ago
Attachment #436989 - Flags: review?(joshmoz) → review+

Comment 13

9 years ago
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/72c7b128abaa
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Summary: [OOPP] Whitelist and Blacklist Plug-ins on OSX → [OOPP] Whitelist Flash 10.1+ and JavaPlugin2 on Mac OS X
(Assignee)

Updated

9 years ago
Blocks: 557213

Comment 14

9 years ago
JavaPlugin2 name fixed in followup:

http://hg.mozilla.org/mozilla-central/rev/1147cf4cdf63
You need to log in before you can comment on or make changes to this bug.