556123 - Move the setting of comments and work_time into Bugzilla::Bug::set_all

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Max Kanat-Alexander]

This is the second step for set_all. I've moved basic field setting to using set_all, now it's time to actually have a Bugzilla::Bug::set_all that does some custom stuff.

Comment 1

[Max Kanat-Alexander]

  In the interest of simplicity, I'm going to limit this to just comments, since this is the first actual set_all implementation in Bugzilla::Bug.

Comment 2

[Max Kanat-Alexander]

Attachment: v1

Here we go. Relatively simple patch.

  I made "comment" get passed as a hash so that there's no confusion about whether we're setting something about existing comments or about the current comment, and to make things easier for eventual WebServices implementations using set_all.

  Instead of specifically listing every single field that can be set using normal set_ functions in Bugzilla::Bug, I made set_all in Bugzilla::Bug check can() to determine which of the input parameters are valid set_* functions. This should, to some degree, allow for easy extension of Bugzilla::Bug::set_all, also.

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 436076 [details] [diff] [review]
v1

Code looks fine to me. Also tested it in several different scenarios and worked as expected. r=dkl

Comment 4

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified process_bug.cgi
modified Bugzilla/Bug.pm
Committed revision 7158.