556125 - Talos needs to test x86_64 mac builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Mike Taylor [:bear]]

Add the appropriate config changes to introduce x86_64 to talos-staging

Comment 1

[Mike Taylor [:bear]]

Attachment: [WIP] Add x86_64 to supported platforms

the worry I have is that builds are not done for anything except mozilla-central but the pattern in config.py seems to assume all platforms do all builds - do I need to adjust the assumption?

Comment 2

[alice nodelman [:alice] [:anode]]

To run only on moz-central you'd need to add x86_64 to ALL_PLATFORMS, then create something that is a subset (the way that we have NO_WIN for tests that don't run on windows platforms) that excludes x86_64 and then use that for every branch that shouldn't call this test.

Comment 3

[alice nodelman [:alice] [:anode]]

On second consideration, I'm also a little confused here.  Are we talking about tests that should only be run on snow leopard?  If so then the set up should be different.  Otherwise are you talking about only running these builds on a platform that we do not yet have?

Comment 4

[Mike Taylor [:bear]]

I was just trying to see if I could help by adding the new 10.6 slaves to the Talos test list.  The new slaves are building mozilla-central only for right now.

Comment 5

[[e-mail] (:bhearsum)]

I'm updating the summary to be more clear. What we want to do here is have the upcoming x86_64 only Mac builds tested on the 10.6 Talos slaves, with both unit tests and Talos running.

Comment 6

[alice nodelman [:alice] [:anode]]

Comment on attachment 436040 [details] [diff] [review]
[WIP] Add x86_64 to supported platforms

Now that I understand what's going on, I think that this would be okay for staging and we can work out the rest of the kinks there.

Comment 7

[Mike Taylor [:bear]]

Comment on attachment 436040 [details] [diff] [review]
[WIP] Add x86_64 to supported platforms

am I able to commit for talos-staging?  if not who is the gatekeeper?

Comment 8

[Mike Taylor [:bear]]

Attachment: [WIP] Add x86_64 to supported platforms

caught a couple spots where the new platform was required to prevent runtime errors on talos-staging-pool2

Comment 9

[Mike Taylor [:bear]]

Attachment: [WIP] changes to buildbotcustom misc.py

changed to misc.py to support new builddir_suffix key to prevent the rule error about builddir names being the same

Comment 10

[Mike Taylor [:bear]]

Attachment: [WIP] Add x86_64 to supported platforms

Comment 11

[Mike Taylor [:bear]]

Attachment: buildbotcustom changes for macosx64

Comment 12

[Mike Taylor [:bear]]

Attachment: buildbot-configs changes for macosx64

Comment 13

[alice nodelman [:alice] [:anode]]

Did you get a run where the slaves were tipped off correctly (ie, 32bit mac build generated tests on leopard + snow leopard, 64bit mac build generated tests on snow leopard only) ?  The construction looks correct to me, but I want to be sure that we've had a successful run before giving this a stamp.

Comment 14

[Mike Taylor [:bear]]

I got stopped by not being able to attach a talos staging slave to the talos staging master

Comment 15

[Mike Taylor [:bear]]

(In reply to comment #14)
> I got stopped by not being able to attach a talos staging slave to the talos
> staging master

issue was my info-set which alice corrected (not realizing the breakdown of the 3 talos snow leopard slaves and the location of buildbot.tac for talos slaves)

Comment 16

[alice nodelman [:alice] [:anode]]

This is currently blocked on bug 557910.

Comment 17

[alice nodelman [:alice] [:anode]]

Fixed by bug 557910 - macosx 64bit builds now being testing on snow leopard.