Closed Bug 556151 Opened 14 years ago Closed 14 years ago

Syntax highlighting can overflow the call stack

Categories

(Skywriter Graveyard :: Syntax Highlighting, defect)

Product:
Skywriter Graveyard
Component:
Syntax Highlighting
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: pcwalton, Assigned: pcwalton)

Details

If the syntax highlighter has too much work to do, the call stack can overflow, because of the lack of tail calls in JavaScript. It should be enough to add a window.setTimeout(0) call to get a "fake tail call" to fix this one.
We're going to need to get this one fixed. I get a "too much recursion" error 
fairly often (just try navigating to the end of a file and you can hit this 
quite easily...)
Target Milestone: --- → 0.7.2
Assignee: nobody → pwalton
Should be fixed as of changeset 6763defc2cec.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: 0.7.2 → 0.7.1
You need to log in before you can comment on or make changes to this bug.