556240 - Profiler broken, clearing activegc then doing work

Status: VERIFIED FIXED

(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P1)

Description

[Tommy Reilly]

This is backwards:

       m_gc->heap->SetActiveGC(m_prevgc);  // <- m_prevgc = 0
       GCAssert(curgc == m_gc);
		m_gc->ThreadLeave(doCollectionWork); // <- currently executing

We made it that way because we can't release the lock in ThreaedLeave until after the active gc is cleared.  The order of operations needs to be:

// do exit work
// pop active gc
// release lock

right now its 

// pop active gc
// do exit work
// release lock

Comment 1

[Tommy Reilly]

Attachment: make sure we are the active GC when any GC work is performed

Comment 2

[Tommy Reilly]

pushed in tamarin-redux-argo: 3901:d043ba13e7d4
we need a selftest for this leaving open

Comment 3

[Tommy Reilly]

http://hg.mozilla.org/tamarin-redux/rev/d043ba13e7d4
resolving, will open new bug for selftests

Comment 4

[Brent Baker]

(In reply to comment #3)
> http://hg.mozilla.org/tamarin-redux/rev/d043ba13e7d4
> resolving, will open new bug for selftests

Tom what is bug # that is tracking the selftest?

Comment 5

[Tommy Reilly]

https://bugzilla.mozilla.org/show_bug.cgi?id=556765