Closed
Bug 556256
Opened 14 years ago
Closed 14 years ago
Explicitly set MOZ_MORKREADER and MOZ_MORK for Thunderbird and SeaMonkey, and sync enable places changes from bug 516758
Categories
(MailNews Core :: Build Config, defect)
MailNews Core
Build Config
Tracking
(thunderbird3.1 beta2-fixed)
RESOLVED
FIXED
Thunderbird 3.1b2
Tracking | Status | |
---|---|---|
thunderbird3.1 | --- | beta2-fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
2.80 KB,
patch
|
Callek
:
review+
|
Details | Diff | Splinter Review |
Following on from bug 516758 and before bug 556253 happens, I want to: - explicitly set MOZ_MORK and MOZ_MORKREADER in confvars.sh for Thunderbird & SeaMonkey. -- Bug 556253 will be setting the default to MOZ_MORKREADER=1 and MOZ_MORK= -- Note that both apps will have MOZ_MORK set to 1 as we both build mailnews. -- Thunderbird will clear MOZ_MORKREADER as it doesn't currently need that. SeaMonkey doesn't need to add it, as it builds places and therefore needs the mork reader. -- SeaMonkey can have the MOZ_PLACES=1 removed as bug 516758 has set it by default. - remove the --enable-places option as bug 516758 has done. This won't affect 1.9.2 as: - SeaMonkey doesn't build there. - Thunderbird will just be explicit about what it is/isn't building. - I don't care about --enable-places on 1.9.2, but in any case this removing the option from comm-central configure.in wouldn't have a bearing on that.
Attachment #436174 -
Flags: review?(bugspam.Callek)
Comment 1•14 years ago
|
||
Comment on attachment 436174 [details] [diff] [review] The fix note: m-c has applied a bustage fix for their landing that assists us here, might be good to get that backed out while your at it :-) http://hg.mozilla.org/mozilla-central/rev/aea2b08ae4a3
Attachment #436174 -
Flags: review?(bugspam.Callek) → review+
Assignee | ||
Comment 2•14 years ago
|
||
(In reply to comment #1) > (From update of attachment 436174 [details] [diff] [review]) > note: m-c has applied a bustage fix for their landing that assists us here, > might be good to get that backed out while your at it :-) > > http://hg.mozilla.org/mozilla-central/rev/aea2b08ae4a3 Yes, that's why we're doing this bug and bug 556253
Assignee | ||
Comment 3•14 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/3179601351f1
Status: NEW → RESOLVED
Closed: 14 years ago
status-thunderbird3.1:
--- → beta2-fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1b2
Assignee | ||
Updated•14 years ago
|
Flags: in-testsuite-
Comment 4•14 years ago
|
||
Could you put AC_SUBST(MOZ_PLACES) back were it stayed in m-c? Were these changes actually meant for *-1.9.2, whereas bug 556253 was pushed to m-c only?
Assignee | ||
Comment 5•14 years ago
|
||
(In reply to comment #4) > Were these changes actually meant for *-1.9.2, whereas bug 556253 was pushed to > m-c only? Try reading comment 0.
You need to log in
before you can comment on or make changes to this bug.
Description
•